Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(267137)

#18135: _ssl module: possible integer overflow for very long strings (+2^31 bytes)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 2 months ago by vstinner
Modified:
6 years, 1 month ago
Reviewers:
pitrou
CC:
terry.reedy, AntoinePitrou, haypo, devnull_psf.upfronthosting.co.za, storchaka
Visibility:
Public.

Patch Set 1 #

Total comments: 1

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Misc/NEWS View 1 1 chunk +3 lines, -3 lines 0 comments Download
Modules/_ssl.c View 1 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 1
AntoinePitrou
6 years, 1 month ago #1
http://bugs.python.org/review/18135/diff/8462/Modules/_ssl.c
File Modules/_ssl.c (right):

http://bugs.python.org/review/18135/diff/8462/Modules/_ssl.c#newcode1294
Modules/_ssl.c:1294: len = SSL_write(self->ssl, buf.buf, len);
len is never initialized?
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+