Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(162207)

#18111: Add a default argument to min & max

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 5 months ago by Julian+Python.org
Modified:
6 years, 5 months ago
Reviewers:
storchaka
CC:
gvanrossum, Thomas Wouters, rhettinger, Nick Coghlan, nedbat, eric.araujo, doug_doughellmann.com, r.david.murray, skrah, dave_dabeaz.com, Julian, devnull_psf.upfronthosting.co.za, pconnell
Visibility:
Public.

Patch Set 1 #

Total comments: 6

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/functions.rst View 1 2 chunks +22 lines, -14 lines 0 comments Download
Lib/test/test_builtin.py View 1 4 chunks +28 lines, -0 lines 0 comments Download
Python/bltinmodule.c View 1 3 chunks +26 lines, -14 lines 0 comments Download

Messages

Total messages: 2
storchaka_gmail.com
http://bugs.python.org/review/18111/diff/8315/Doc/library/functions.rst File Doc/library/functions.rst (right): http://bugs.python.org/review/18111/diff/8315/Doc/library/functions.rst#newcode763 Doc/library/functions.rst:763: iterable (such as a non-empty string, tuple or list). ...
6 years, 5 months ago #1
Julian
6 years, 5 months ago #2
Thanks for the review Serhiy. New patchset addressing comments incoming.

http://bugs.python.org/review/18111/diff/8315/Doc/library/functions.rst
File Doc/library/functions.rst (right):

http://bugs.python.org/review/18111/diff/8315/Doc/library/functions.rst#newco...
Doc/library/functions.rst:763: iterable (such as a non-empty string, tuple or
list).  The largest item
Good catch. Fixed.

http://bugs.python.org/review/18111/diff/8315/Lib/test/test_builtin.py
File Lib/test/test_builtin.py (right):

http://bugs.python.org/review/18111/diff/8315/Lib/test/test_builtin.py#newcod...
Lib/test/test_builtin.py:847: self.assertRaises(TypeError, min)
Yup, whoops. Thanks.

http://bugs.python.org/review/18111/diff/8315/Lib/test/test_builtin.py#newcod...
Lib/test/test_builtin.py:881: self.assertEqual(max((1, 2), default=1, key=neg),
1)
On 2013/06/08 12:28:06, storchaka wrote:
> Perhaps here other default will be better. I.e. 3.

Done.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+