Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(74963)

#17914: add os.cpu_count()

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 3 months ago by cf.natali
Modified:
6 years, 2 months ago
Reviewers:
storchaka, gessau
CC:
AntoinePitrou, haypo, giampaolo.rodola, nedbat, mark_qtrac.eu, trent, ezio.melotti, r.david.murray, Charles-François Natali, devnull_psf.upfronthosting.co.za, storchaka, kushaldas, stefan_drees.name, Yogesh.Chaudhari
Visibility:
Public.

Patch Set 1 #

Total comments: 3

Patch Set 2 #

Patch Set 3 #

Patch Set 4 #

Total comments: 3

Patch Set 5 #

Total comments: 3

Patch Set 6 #

Patch Set 7 #

Total comments: 4

Patch Set 8 #

Total comments: 1

Patch Set 9 #

Patch Set 10 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/multiprocessing.rst View 1 2 3 4 5 6 7 8 9 1 chunk +3 lines, -3 lines 0 comments Download
Lib/concurrent/futures/process.py View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
Lib/multiprocessing/pool.py View 1 2 3 4 5 6 7 8 9 2 chunks +3 lines, -5 lines 0 comments Download
Lib/test/regrtest.py View 1 2 3 4 5 6 7 8 9 1 chunk +3 lines, -6 lines 1 comment Download

Messages

Total messages: 6
storchaka_gmail.com
http://bugs.python.org/review/17914/diff/8118/Lib/multiprocessing/__init__.py File Lib/multiprocessing/__init__.py (right): http://bugs.python.org/review/17914/diff/8118/Lib/multiprocessing/__init__.py#newcode89 Lib/multiprocessing/__init__.py:89: if num == None: if num is None: http://bugs.python.org/review/17914/diff/8118/Lib/os.py ...
6 years, 3 months ago #1
Charles-François Natali
http://bugs.python.org/review/17914/diff/8127/Lib/os.py File Lib/os.py (right): http://bugs.python.org/review/17914/diff/8127/Lib/os.py#newcode1021 Lib/os.py:1021: def cpu_count(): This wrapper is useless, all functions defined ...
6 years, 3 months ago #2
Charles-François Natali
http://bugs.python.org/review/17914/diff/8136/Lib/os.py File Lib/os.py (right): http://bugs.python.org/review/17914/diff/8136/Lib/os.py#newcode28 Lib/os.py:28: import posix Really, this is useless, all the content ...
6 years, 3 months ago #3
Charles-François Natali
http://bugs.python.org/review/17914/diff/8146/Modules/posixmodule.c File Modules/posixmodule.c (right): http://bugs.python.org/review/17914/diff/8146/Modules/posixmodule.c#newcode10317 Modules/posixmodule.c:10317: or Py_None if this value cannot be established."); Py_None ...
6 years, 3 months ago #4
Charles-François Natali
Apart from this typo, looks good to me. I'll commit it next week, unless someone ...
6 years, 3 months ago #5
HenryG
6 years, 2 months ago #6
http://bugs.python.org/review/17914/diff/8198/Lib/test/regrtest.py
File Lib/test/regrtest.py (right):

http://bugs.python.org/review/17914/diff/8198/Lib/test/regrtest.py#newcode513
Lib/test/regrtest.py:513: use_mp = 2 + ncpu
Why the intermediate variable?
  use_mp = 2 + (os.cpu_count() or 1)
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+