Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(28)

#17849: Missing size argument in readline() method for httplib's class LineAndFileWrapper

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 1 month ago by miroslav.stampar
Modified:
2 years, 5 months ago
Reviewers:
graffatcolmingov, vadmium+py, cory
CC:
orsenthil, AntoinePitrou, christian.heimes, r.david.murray, devnull_psf.upfronthosting.co.za, berkerpeksag, Martin Panter, storchaka, miroslav.stampar_gmail.com, icordasc, demian, adam_brenecki.id.au, rob.raymond_hp.com, Lukasa, steve_lonetwin.net, tardyp_gmail.com, pythonbugs_shalmirane.com, dev_null_mail_yahoo.com
Visibility:
Public.

Patch Set 1 #

Total comments: 5

Patch Set 2 #

Patch Set 3 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/httplib.py View 1 2 1 chunk +3 lines, -1 line 0 comments Download
Lib/test/test_httplib.py View 1 2 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 4
icordasc
http://bugs.python.org/review/17849/diff/10607/Lib/httplib.py File Lib/httplib.py (right): http://bugs.python.org/review/17849/diff/10607/Lib/httplib.py#newcode1327 Lib/httplib.py:1327: return self._file.readline(amt) Perhaps a comment could explain that this ...
4 years ago #1
icordasc
This looks good to me.
3 years, 8 months ago #2
Martin Panter
http://bugs.python.org/review/17849/diff/10607/Lib/httplib.py File Lib/httplib.py (right): http://bugs.python.org/review/17849/diff/10607/Lib/httplib.py#newcode1329 Lib/httplib.py:1329: s = self._line[self._line_offset:] Is it valid to ignore or ...
2 years, 5 months ago #3
Lukasa
2 years, 5 months ago #4
Alright, feedback received. I'll upload a new patch.

https://bugs.python.org/review/17849/diff/10607/Lib/httplib.py
File Lib/httplib.py (right):

https://bugs.python.org/review/17849/diff/10607/Lib/httplib.py#newcode1327
Lib/httplib.py:1327: return self._file.readline(amt)
On 2014/02/01 20:17:54, icordasc wrote:
> Perhaps a comment could explain that this is necessary to facilitate the
> LineAndFileWrapper class?

Done.

https://bugs.python.org/review/17849/diff/10607/Lib/httplib.py#newcode1329
Lib/httplib.py:1329: s = self._line[self._line_offset:]
On 2015/09/02 02:43:38, vadmium wrote:
> Is it valid to ignore or exceed “amt” here?

Probably not. I'll update the patch to more closely follow the logic of read()
here.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7