Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(81128)

#17839: base64 module should use memoryview

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 6 months ago by ncoghlan
Modified:
6 years, 5 months ago
Reviewers:
ezio.melotti
CC:
barry, Nick Coghlan, AntoinePitrou, haypo, ezio.melotti, devnull_psf.upfronthosting.co.za, storchaka, kushaldas
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 7

Patch Set 3 #

Patch Set 4 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/base64.rst View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
Doc/library/codecs.rst View 1 2 3 1 chunk +34 lines, -29 lines 0 comments Download
Lib/base64.py View 1 2 3 6 chunks +15 lines, -16 lines 0 comments Download
Lib/test/test_base64.py View 1 2 3 12 chunks +56 lines, -3 lines 0 comments Download
Lib/test/test_codecs.py View 1 2 3 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 3
ezio.melotti
http://bugs.python.org/review/17839/diff/8016/Doc/library/base64.rst File Doc/library/base64.rst (right): http://bugs.python.org/review/17839/diff/8016/Doc/library/base64.rst#newcode31 Doc/library/base64.rst:31: Any :ref:`bytes-like objects <bufferobjects>` are now accepted by the ...
6 years, 6 months ago #1
Nick Coghlan
http://bugs.python.org/review/17839/diff/8016/Lib/base64.py File Lib/base64.py (right): http://bugs.python.org/review/17839/diff/8016/Lib/base64.py#newcode41 Lib/base64.py:41: return memoryview(s).tobytes() While I don't believe the current incarnation ...
6 years, 5 months ago #2
Nick Coghlan
6 years, 5 months ago #3
Ignore my review, it's wrong because I was looking at the patch out of context.
See my comments on the tracker issue.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+