Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(201679)

#17764: Support http.server passing bind address via commend line argument

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 7 months ago by python
Modified:
6 years, 7 months ago
Reviewers:
berker.peksag
CC:
orsenthil, r.david.murray, devnull_psf.upfronthosting.co.za, berkerpeksag, malte.swart
Visibility:
Public.

Patch Set 1 #

Total comments: 6

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/http.server.rst View 1 1 chunk +9 lines, -0 lines 0 comments Download
Lib/http/server.py View 1 2 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 2
berkerpeksag
http://bugs.python.org/review/17764/diff/7904/Lib/http/server.py File Lib/http/server.py (right): http://bugs.python.org/review/17764/diff/7904/Lib/http/server.py#newcode1186 Lib/http/server.py:1186: ServerClass = HTTPServer, protocol="HTTP/1.0", port=8000, bind=''): Nit: I would ...
6 years, 7 months ago #1
launchpad_malteswart.de
6 years, 7 months ago #2
I have added a new patch version to the issue (I did not found a way to update
the patch inside Rietveld).

http://bugs.python.org/review/17764/diff/7904/Lib/http/server.py
File Lib/http/server.py (right):

http://bugs.python.org/review/17764/diff/7904/Lib/http/server.py#newcode1186
Lib/http/server.py:1186: ServerClass = HTTPServer, protocol="HTTP/1.0",
port=8000, bind=''):
On 2013/04/19 18:07:03, berkerpeksag wrote:
> Nit: I would use double quotes to be more consistent here. 
> 
> Nit 2: You could remove spaces around the = sign (e.g. HandlerClass,
> ServerClass).

Done.

http://bugs.python.org/review/17764/diff/7904/Lib/http/server.py#newcode1211
Lib/http/server.py:1211: parser.add_argument('--bind', '-b', action='store',
On 2013/04/19 18:07:03, berkerpeksag wrote:
> 'store' is the default action. You don't have to use it explicitly. See:
> http://docs.python.org/3/library/argparse.html#action

Done. I also removed the type=str option

http://bugs.python.org/review/17764/diff/7904/Lib/http/server.py#newcode1213
Lib/http/server.py:1213: help='Specify alternate bind address [default: all
interfaces]')
On 2013/04/19 18:07:03, berkerpeksag wrote:
> We should limit line length to 79 characters here.

Done.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+