mock.patch could whitelist builtins to not need create=True

[eric.araujo]

http://bugs.python.org/review/17660/diff/7799/Lib/unittest/mock.py
File Lib/unittest/mock.py (right):

http://bugs.python.org/review/17660/diff/7799/Lib/unittest/mock.py#newcode1146
Lib/unittest/mock.py:1146: if name in __builtins__ and isinstance(target,
ModuleType):
__builtins__ is a CPython implementation detail; this should use the builtins
module instead (a little harder, as this module contains things like __doc__
that are not built-in functions or types).

[berkerpeksag]

http://bugs.python.org/review/17660/diff/7799/Doc/library/unittest.mock.rst
File Doc/library/unittest.mock.rst (right):

http://bugs.python.org/review/17660/diff/7799/Doc/library/unittest.mock.rst#n...
Doc/library/unittest.mock.rst:1037: to pass `create=True`, it will be added by
default.
``create=True``

http://bugs.python.org/review/17660/diff/7799/Doc/library/unittest.mock.rst#n...
Doc/library/unittest.mock.rst:1414: builtin `ord`:
`ord` -> :func:`ord`

http://bugs.python.org/review/17660/diff/7799/Doc/library/unittest.mock.rst#n...
Doc/library/unittest.mock.rst:1422: 101
It would be good if you add the actual result of ``ord('c')``. Something like:

    >>> test()
    101
    >>> ord('c')
    99

[eric.araujo]

http://bugs.python.org/review/17660/diff/7799/Doc/library/unittest.mock.rst
File Doc/library/unittest.mock.rst (right):

http://bugs.python.org/review/17660/diff/7799/Doc/library/unittest.mock.rst#n...
Doc/library/unittest.mock.rst:1037: to pass `create=True`, it will be added by
default.
I agree the use of single backticks is unfortunate (not explicit, not in line
with the rest of the Python doc), but that’s what the rest of the document uses.

[Michael Foord]

http://bugs.python.org/review/17660/diff/7799/Lib/unittest/mock.py
File Lib/unittest/mock.py (right):

http://bugs.python.org/review/17660/diff/7799/Lib/unittest/mock.py#newcode1146
Lib/unittest/mock.py:1146: if name in __builtins__ and isinstance(target,
ModuleType):
On 2014/04/11 08:20:04, eric.araujo wrote:
> __builtins__ is a CPython implementation detail; this should use the builtins
> module instead (a little harder, as this module contains things like __doc__
> that are not built-in functions or types).

I agree with Eric here.

[eric.araujo]

http://bugs.python.org/review/17660/diff/11569/Lib/unittest/mock.py
File Lib/unittest/mock.py (right):

http://bugs.python.org/review/17660/diff/11569/Lib/unittest/mock.py#newcode35
Lib/unittest/mock.py:35: _builtins = {name for name in dir(builtins) if not
name.startswith('-')}
I think you meant _, not - :)