Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(173)

#17618: base85 encoding

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 8 months ago by pitrou
Modified:
4 years ago
Reviewers:
storchaka
CC:
jcea, AntoinePitrou, haypo, christian.heimes, r.david.murray, flox, sijinjoseph, devnull_psf.upfronthosting.co.za, storchaka, isoschiz, glasper9_yahoo.com.au
Visibility:
Public.

Patch Set 1 #

Total comments: 10

Patch Set 2 #

Total comments: 4

Patch Set 3 #

Patch Set 4 #

Total comments: 5

Patch Set 5 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/base64.rst View 1 2 3 4 1 chunk +70 lines, -0 lines 0 comments Download
Lib/base64.py View 1 2 3 4 4 chunks +190 lines, -1 line 1 comment Download
Lib/test/test_base64.py View 1 2 3 4 2 chunks +252 lines, -2 lines 2 comments Download

Messages

Total messages: 5
storchaka_gmail.com
http://bugs.python.org/review/17618/diff/7936/Lib/base64.py File Lib/base64.py (right): http://bugs.python.org/review/17618/diff/7936/Lib/base64.py#newcode345 Lib/base64.py:345: encoded.append(_B85START) Adobe's prefix should be accounted for wrapping. http://bugs.python.org/review/17618/diff/7936/Lib/base64.py#newcode367 ...
4 years, 7 months ago #1
storchaka_gmail.com
Self-reviewing. http://bugs.python.org/review/17618/diff/7947/Lib/base64.py File Lib/base64.py (right): http://bugs.python.org/review/17618/diff/7947/Lib/base64.py#newcode320 Lib/base64.py:320: b += b'\0' * padding Should be b ...
4 years, 7 months ago #2
storchaka_gmail.com
http://bugs.python.org/review/17618/diff/9945/Lib/base64.py File Lib/base64.py (right): http://bugs.python.org/review/17618/diff/9945/Lib/base64.py#newcode449 Lib/base64.py:449: % (i + j)) ... from None Extra exception ...
4 years ago #3
storchaka_gmail.com
http://bugs.python.org/review/17618/diff/9954/Lib/base64.py File Lib/base64.py (right): http://bugs.python.org/review/17618/diff/9954/Lib/base64.py#newcode387 Lib/base64.py:387: raise ValueError('Ascii85 overflow') ... from None http://bugs.python.org/review/17618/diff/9954/Lib/test/test_base64.py File Lib/test/test_base64.py ...
4 years ago #4
AntoinePitrou
4 years ago #5
http://bugs.python.org/review/17618/diff/9954/Lib/test/test_base64.py
File Lib/test/test_base64.py (right):

http://bugs.python.org/review/17618/diff/9954/Lib/test/test_base64.py#newcode109
Lib/test/test_base64.py:109: # XXX why is b64encode hardcoded here?
On 2013/11/17 22:49:18, storchaka wrote:
> I think f should be here.

Except that it doesn't work with existing tests, which is why I've left a XXX
there :-) (it can be tackled in another issue)
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7