Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(50122)

#17516: Dead code should be removed

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 7 months ago by vstinner
Modified:
6 years, 6 months ago
Reviewers:
ezio.melotti
CC:
Georg, rhettinger, haypo, ezio.melotti, r.david.murray, tshepang, devnull_psf.upfronthosting.co.za
Visibility:
Public.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/datetime.py View 1 chunk +195 lines, -195 lines 0 comments Download
Lib/email/_header_value_parser.py View 1 chunk +16 lines, -18 lines 0 comments Download
Lib/pickletools.py View 1 chunk +111 lines, -112 lines 0 comments Download
Lib/_pyio.py View 1 chunk +0 lines, -1 line 0 comments Download
Lib/sre_compile.py View 1 chunk +0 lines, -7 lines 0 comments Download
Lib/test/test_posix.py View 1 chunk +0 lines, -18 lines 1 comment Download
Tools/scripts/reindent.py View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 1
ezio.melotti
6 years, 6 months ago #1
http://bugs.python.org/review/17516/diff/7682/Lib/test/test_posix.py
File Lib/test/test_posix.py (right):

http://bugs.python.org/review/17516/diff/7682/Lib/test/test_posix.py#newcode683
Lib/test/test_posix.py:683: support.rmtree(base_path)
The whole test was added here:
http://hg.python.org/cpython/diff/81fd8a8baa9a/Lib/test/test_posix.py
but it was disabled from the start.

We should either remove the return and see if it works, or remove the whole
test.

http://bugs.python.org/review/17516/diff/7682/Tools/scripts/reindent.py
File Tools/scripts/reindent.py (right):

http://bugs.python.org/review/17516/diff/7682/Tools/scripts/reindent.py#newco...
Tools/scripts/reindent.py:56: # A specified newline to be used in the output
(set by --newline option)
I would move this before the previous line.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+