Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(33222)

#17481: inspect.getfullargspec could use __signature__

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 5 months ago by michael
Modified:
5 years, 4 months ago
Reviewers:
larry, ncoghlan, yselivanov.ml
CC:
terry.reedy, Nick Coghlan, larry, Michael Foord, Claudiu.Popa, Yury.Selivanov, devnull_psf.upfronthosting.co.za, Yury Selivanov
Visibility:
Public.

Patch Set 1 #

Total comments: 4

Patch Set 2 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/inspect.py View 1 2 chunks +84 lines, -6 lines 2 comments Download
Lib/test/test_inspect.py View 1 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 4
larry
http://bugs.python.org/review/17481/diff/10531/Lib/test/test_inspect.py File Lib/test/test_inspect.py (right): http://bugs.python.org/review/17481/diff/10531/Lib/test/test_inspect.py#newcode569 Lib/test/test_inspect.py:569: def test_getfullargspec_signature(self): This doesn't test inspect.getfullargspec(). It doesn't even ...
5 years, 5 months ago #1
Nick Coghlan
The general approach and specific patch look good to me, but the lack of explicit ...
5 years, 5 months ago #2
Nick Coghlan
Generally looks good to me, but I suggest retrieving the name of the bound first ...
5 years, 4 months ago #3
Yury.Selivanov
5 years, 4 months ago #4
http://bugs.python.org/review/17481/diff/10531/Lib/test/test_inspect.py
File Lib/test/test_inspect.py (right):

http://bugs.python.org/review/17481/diff/10531/Lib/test/test_inspect.py#newco...
Lib/test/test_inspect.py:575: self.assertFullArgSpecEquals(test,
args_e=['spam'], formatted='(spam)')
Right. Missed this one before committing the main patch. Committed separately in
0fa2750c7241
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+