Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(272545)

#17413: format_exception() breaks on exception tuples from trace function

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 4 months ago by inform
Modified:
6 years, 4 months ago
Reviewers:
rdmurray
CC:
inform_tiker.net, Benjamin Peterson, r.david.murray, Aaron.Meurer, devnull_psf.upfronthosting.co.za, jarausch_igpm.rwth-aachen.de, ingrid, bmac325_gmail.com
Visibility:
Public.

Patch Set 1 #

Total comments: 2

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/test/test_sys_settrace.py View 1 1 chunk +19 lines, -0 lines 0 comments Download
Misc/ACKS View 1 2 chunks +2 lines, -0 lines 0 comments Download
Python/ceval.c View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 1
r.david.murray
6 years, 4 months ago #1
A couple of FYIs.

http://bugs.python.org/review/17413/diff/7872/Lib/test/test_sys_settrace.py
File Lib/test/test_sys_settrace.py (right):

http://bugs.python.org/review/17413/diff/7872/Lib/test/test_sys_settrace.py#n...
Lib/test/test_sys_settrace.py:463: x = 5
This is fine, but just FYI, we often use 1/0 in tests when we want to raise an
exception.

http://bugs.python.org/review/17413/diff/7872/Lib/test/test_sys_settrace.py#n...
Lib/test/test_sys_settrace.py:469: if not isinstance(exception, Exception):
You could use self.assertIsInstance(exception, Exception) here.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+