Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(85178)

#17386: Bring Doc/make.bat as close to Doc/Makefile as possible

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 8 months ago by zachary.ware
Modified:
5 years, 6 months ago
Reviewers:
ezio.melotti
CC:
terry.reedy, christian.heimes, tim.golden, ezio.melotti, brian.curtin, docs_python.org, devnull_psf.upfronthosting.co.za, Zach Ware
Visibility:
Public.

Patch Set 1 #

Total comments: 1

Patch Set 2 #

Patch Set 3 #

Total comments: 8

Patch Set 4 #

Patch Set 5 #

Patch Set 6 #

Patch Set 7 #

Patch Set 8 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/make.bat View 1 2 3 4 5 6 7 1 chunk +103 lines, -26 lines 0 comments Download
Doc/Makefile View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
Doc/README.txt View 1 2 3 4 5 6 7 4 chunks +23 lines, -6 lines 0 comments Download

Messages

Total messages: 3
Zach Ware
Just leaving a note about a bug I stumbled onto. http://bugs.python.org/review/17386/diff/7558/Doc/make.bat File Doc/make.bat (right): http://bugs.python.org/review/17386/diff/7558/Doc/make.bat#newcode82 ...
6 years, 8 months ago #1
ezio.melotti
http://bugs.python.org/review/17386/diff/7596/Doc/README.txt File Doc/README.txt (right): http://bugs.python.org/review/17386/diff/7596/Doc/README.txt#newcode43 Doc/README.txt:43: make html "PYTHON=python" Does "make html" work without specifying ...
6 years, 7 months ago #2
Zach Ware
6 years, 7 months ago #3
Thanks for the comments, Ezio.

http://bugs.python.org/review/17386/diff/7596/Doc/README.txt
File Doc/README.txt (right):

http://bugs.python.org/review/17386/diff/7596/Doc/README.txt#newcode43
Doc/README.txt:43: make html "PYTHON=python"
On 2013/04/10 17:38:23, ezio.melotti wrote:
> Does "make html" work without specifying "PYTHON=python" (assuming that
"python"
> is a recognised command)?

Yes, that's a large part of the point of the patch to Doc/make.bat, actually :)

> If "python" is not a recognised command, I guess that 
> `make html "PYTHON=C:\Python27\python.exe"` can be used instead.  Is the
syntax
> correct?  Maybe this could be added too here.

Exactly.  And yes, that syntax is correct, and that is a much better example. 
Next version of the patch will change to `make html
"PYTHON=C:\Python27\python.exe"`

http://bugs.python.org/review/17386/diff/7596/Doc/README.txt#newcode90
Doc/README.txt:90: A "make update" cleans up all builds and updates the
Subversion checkouts of
On 2013/04/10 17:38:23, ezio.melotti wrote:
> Why this is not in the list?

Just because it wasn't before.  I'm fine with adding it to the list.

> Also on Linux there's "make htmlview", not sure if it's available on Windows
too
> though.

Not yet :).  'htmlview' is undocumented even in the Makefile help message,
though (that's why it's not present in the make.bat patch yet); next version of
the patch will add 'htmlview' on Windows, document it in Makefile, and add it
and any other missing targets to README.txt ('clean', for example).

http://bugs.python.org/review/17386/diff/7596/Doc/README.txt#newcode117
Doc/README.txt:117: svn co
http://svn.python.org/projects/external/Pygments-1.5dev-20120930/pygments
tools/pygments
On 2013/04/10 17:38:23, ezio.melotti wrote:
> Any reason why a dev version is suggested?  Is this the version we are
currently
> using?

Yep, that's what's listed in Makefile and make.bat currently.

http://bugs.python.org/review/17386/diff/7596/Doc/make.bat
File Doc/make.bat (right):

http://bugs.python.org/review/17386/diff/7596/Doc/make.bat#newcode277
Doc/make.bat:277: echo positives, append that file to
tools\sphinxext\susp-ignored.csv.
On 2013/04/10 17:38:23, ezio.melotti wrote:
> On Linux if suspicious markup is found, the build gives an error and this
> message is not printed (see http://bugs.python.org/issue15759).  Does this
work
> here? (You could add a few  ` or : in an rst file to make the suspicious
builder
> suspicious.)

Yes, this message always prints.  Actually, that's probably a bug; it will print
even if Sphinx never even ran, like say if PYTHON isn't a valid command.  I can
fix that either by adding an ERRORLEVEL check to each completion method, or just
make the completion messages more fuzzy ('should be' not 'is', etc).
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+