datetime.time support for '+' and 'now'

Lib/datetime.py

 """Concrete date/time and related types -- prototype implemented in Python.
 
 See http://www.zope.org/Members/fdrake/DateTimeWiki/FrontPage
 
 See also http://dir.yahoo.com/Reference/calendars/
 
 For a primer on DST, including many current DST rules, see
 http://webexhibits.org/daylightsaving/
 
 For more about DST than you ever wanted to know, see
@@ skipping 1042 matching lines @@
     def microsecond(self):
         """microsecond (0-999999)"""
         return self._microsecond
 
     @property
     def tzinfo(self):
         """timezone info object"""
         return self._tzinfo
 
     def __add__(self, other):
         "Add a time and a timedelta"

[sasha, 2013/06/05 23:40:29]

Please use tripple quotes for docstring even when they they are one-line.

         if not isinstance(other, timedelta):
             return NotImplemented
 
         delta = timedelta(hours=self._hour,

[sasha, 2013/06/05 23:40:29]

I would just use a dummy date and do something like

return (datetime.combine(date(2001,1,1), self) + other % timedelta(1)).time()

                           minutes=self._minute,
                           seconds=self._second,
                           microseconds=self._microsecond)
 
         delta += other
         hour, rem = divmod(delta.seconds, 3600)
         minute, second = divmod(rem, 60)
 
-        if delta.days <= _MAXORDINAL:

[Ronald Oussoren, 2013/02/25 08:35:59]

The overflow test is imho not necessary

-            return time(hour, minute, second,
-                        delta.microseconds,
-                        tzinfo=self._tzinfo)
-        raise OverflowError("result out of range")
+        return time(hour, minute, second,
+                    delta.microseconds,
+                    tzinfo=self._tzinfo)
 
     def __sub__(self, other):
         "Subtract a time and a timedelta."
         if isinstance(other, timedelta):
             return self + -other

[Martin Panter, 2019/04/14 02:28:55]

This should be smarter to avoid OverflowError on self - timedelta.max

         return NotImplemented
 
     # Standard conversions, __hash__ (and helpers)
 
     # Comparisons of time objects with other.
 
     def __eq__(self, other):
         if isinstance(other, time):
             return self._cmp(other, allow_mixed=True) == 0
         else:
@@ skipping 45 matching lines @@
         if base_compare:
             return _cmp((self._hour, self._minute, self._second,
                          self._microsecond),
                        (other._hour, other._minute, other._second,
                         other._microsecond))
         if myoff is None or otoff is None:
             if allow_mixed:
                 return 2 # arbitrary non-zero value
             else:
                 raise TypeError("cannot compare naive and aware times")
 

[Ronald Oussoren, 2013/02/25 08:35:59]

Spurious whitespace change

         myhhmm = self._hour * 60 + self._minute - myoff//timedelta(minutes=1)
         othhmm = other._hour * 60 + other._minute - otoff//timedelta(minutes=1)
 
         return _cmp((myhhmm, self._second, self._microsecond),
                     (othhmm, other._second, other._microsecond))
 
     def __hash__(self):
         """Hash."""
         tzoff = self.utcoffset()
         if not tzoff: # zero or None
@@ skipping 1004 matching lines @@
          _check_time_fields, _check_tzinfo_arg, _check_tzname,
          _check_utc_offset, _cmp, _cmperror, _date_class, _days_before_month,
          _days_before_year, _days_in_month, _format_time, _is_leap,
          _isoweek1monday, _math, _ord2ymd, _time, _time_class, _tzinfo_class,
          _wrap_strftime, _ymd2ord)
     # XXX Since import * above excludes names that start with _,
     # docstring does not get overwritten. In the future, it may be
     # appropriate to maintain a single module level docstring and
     # remove the following line.
     from _datetime import __doc__