Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1867)

#17267: datetime.time support for '+' and 'now'

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 2 months ago by ronaldoussoren
Modified:
1 month, 1 week ago
Reviewers:
petri, joar, alexander.belopolsky, vadmium+py
CC:
Ronald Oussoren, sasha, eric.smith, r.david.murray, maker, Petri Lehtinen, francismb, Martin Panter, joar, jbatista, p.ganssle_gmail.com, csabella
Visibility:
Public.

Patch Set 1 #

Total comments: 4

Patch Set 2 #

Patch Set 3 #

Patch Set 4 #

Total comments: 3

Patch Set 5 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/datetime.py View 1 2 3 4 2 chunks +26 lines, -0 lines 3 comments Download
Lib/test/datetimetester.py View 1 2 3 4 3 chunks +62 lines, -0 lines 0 comments Download
Modules/_datetimemodule.c View 1 2 3 4 2 chunks +67 lines, -2 lines 0 comments Download

Messages

Total messages: 5
Petri Lehtinen
http://bugs.python.org/review/17267/diff/7453/Modules/_datetimemodule.c File Modules/_datetimemodule.c (right): http://bugs.python.org/review/17267/diff/7453/Modules/_datetimemodule.c#newcode3829 Modules/_datetimemodule.c:3829: static int Should be static void, because cannot fail ...
6 years, 2 months ago #1
Ronald Oussoren
http://bugs.python.org/review/17267/diff/7468/Lib/datetime.py File Lib/datetime.py (right): http://bugs.python.org/review/17267/diff/7468/Lib/datetime.py#newcode1076 Lib/datetime.py:1076: if delta.days <= _MAXORDINAL: The overflow test is imho ...
6 years, 2 months ago #2
joar
> http://bugs.python.org/review/17267/diff/7468/Modules/_datetimemodule.c > File Modules/_datetimemodule.c (right): > > http://bugs.python.org/review/17267/diff/7468/Modules/_datetimemodule.c#newcode3848 > Modules/_datetimemodule.c:3848: int factor) > I'd ...
6 years, 2 months ago #3
sasha
http://bugs.python.org/review/17267/diff/7481/Lib/datetime.py File Lib/datetime.py (right): http://bugs.python.org/review/17267/diff/7481/Lib/datetime.py#newcode1063 Lib/datetime.py:1063: "Add a time and a timedelta" Please use tripple ...
5 years, 11 months ago #4
Martin Panter
1 month, 1 week ago #5
http://bugs.python.org/review/17267/diff/7481/Lib/datetime.py
File Lib/datetime.py (right):

http://bugs.python.org/review/17267/diff/7481/Lib/datetime.py#newcode1083
Lib/datetime.py:1083: return self + -other
This should be smarter to avoid OverflowError on self - timedelta.max
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+