Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(84044)

#17170: string method lookup is too slow

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 6 months ago by guido
Modified:
6 years, 6 months ago
Reviewers:
amauryfa
CC:
gvanrossum, barry, terry.reedy, jcea, amaury.forgeotdarc, Nick Coghlan, AntoinePitrou, scoder, haypo, larry, ezio.melotti, flox, BreamoreBoy, Mark.Shannon, devnull_psf.upfronthosting.co.za, storchaka, Yury Selivanov, isoschiz, Josh.R
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Python/getargs.c View 1 2 9 chunks +30 lines, -24 lines 2 comments Download

Messages

Total messages: 1
amaury.forgeotdarc
6 years, 6 months ago #1
http://bugs.python.org/review/17170/diff/7340/Python/getargs.c
File Python/getargs.c (right):

http://bugs.python.org/review/17170/diff/7340/Python/getargs.c#newcode202
Python/getargs.c:202: freelistentry_t static_entries[8];
Please replace this 8 with a #defined constant

http://bugs.python.org/review/17170/diff/7340/Python/getargs.c#newcode1594
Python/getargs.c:1594: if (!PyUnicode_CompareWithASCIIString(key, kwlist[i])) {
Before kwlist would accept utf-8 encoded parameter names. This change removes
the feature.

OTOH the current python3 accepts 
   b'h\xe9'.decode(**{'encoding\0garbage': 'latin1'})
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+