Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(74442)

#1712522: urllib.quote throws exception on Unicode URL

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 6 months ago by nagle
Modified:
6 years ago
Reviewers:
volodyaa
CC:
collinw_gmail.com, varmaa_gmail.com, nagle_users.sourceforge.net, orsenthil, AntoinePitrou, haypo, ajaksu_gmail.com, ezio.melotti, eric.araujo, matt.giuca_gmail.com, l.mastrodomenico_gmail.com, khamenya_gmail.com, adam_varud.com
Visibility:
Public.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/urllib.rst View 1 chunk +19 lines, -3 lines 0 comments Download
Lib/test/test_urllib.py View 2 chunks +107 lines, -0 lines 0 comments Download
Lib/urllib.py View 3 chunks +23 lines, -5 lines 2 comments Download

Messages

Total messages: 1
volodyaa
6 years ago #1
Some notes about default parameters.

http://bugs.python.org/review/1712522/diff/1481/Lib/urllib.py
File Lib/urllib.py (right):

http://bugs.python.org/review/1712522/diff/1481/Lib/urllib.py#newcode1216
Lib/urllib.py:1216: if encoding is None:
Is it possible that encoding could be None here (see condition above)?

http://bugs.python.org/review/1712522/diff/1481/Lib/urllib.py#newcode1219
Lib/urllib.py:1219: errors = 'strict'
What about to set those value as default parameter value?
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+