Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(16)

#16954: Add docstrings for ElementTree module

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 11 months ago by storchaka+cpython
Modified:
6 years, 11 months ago
Reviewers:
ezio.melotti, merwok
CC:
ezio.melotti, eli.bendersky, docs_python.org, tshepang, devnull_psf.upfronthosting.co.za, dlam, storchaka
Visibility:
Public.

Patch Set 1 #

Total comments: 18
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/xml/etree/ElementTree.py View 33 chunks +537 lines, -537 lines 18 comments Download

Messages

Total messages: 4
ezio.melotti
http://bugs.python.org/review/16954/diff/7390/Lib/xml/etree/ElementTree.py File Lib/xml/etree/ElementTree.py (right): http://bugs.python.org/review/16954/diff/7390/Lib/xml/etree/ElementTree.py#newcode1 Lib/xml/etree/ElementTree.py:1: """Lightweight XML support for Python 2.3 and later. The ...
6 years, 11 months ago #1
eric.araujo
http://bugs.python.org/review/16954/diff/7390/Lib/xml/etree/ElementTree.py File Lib/xml/etree/ElementTree.py (right): http://bugs.python.org/review/16954/diff/7390/Lib/xml/etree/ElementTree.py#newcode1 Lib/xml/etree/ElementTree.py:1: """Lightweight XML support for Python 2.3 and later. Also ...
6 years, 11 months ago #2
ezio.melotti
http://bugs.python.org/review/16954/diff/7390/Lib/xml/etree/ElementTree.py File Lib/xml/etree/ElementTree.py (right): http://bugs.python.org/review/16954/diff/7390/Lib/xml/etree/ElementTree.py#newcode1 Lib/xml/etree/ElementTree.py:1: """Lightweight XML support for Python 2.3 and later. On ...
6 years, 11 months ago #3
eric.araujo
6 years, 11 months ago #4
http://bugs.python.org/review/16954/diff/7390/Lib/xml/etree/ElementTree.py
File Lib/xml/etree/ElementTree.py (right):

http://bugs.python.org/review/16954/diff/7390/Lib/xml/etree/ElementTree.py#ne...
Lib/xml/etree/ElementTree.py:1: """Lightweight XML support for Python 2.3 and
later.
Duh yes it was minidom.  The fact that I don’t like the etree interface made me
lump it into the same mental category with minidom :)

http://bugs.python.org/review/16954/diff/7390/Lib/xml/etree/ElementTree.py#ne...
Lib/xml/etree/ElementTree.py:27: And a number of child elements stored in a
Python sequence.
Well if there is an attribute named “children” it should be documented like the
other ones (and its English description would still be “child elements”).
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+