Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(86147)

#16914: timestamping in smtplib.py to help troubleshoot server timeouts/delays

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 7 months ago by gavin.chappell
Modified:
4 years, 4 months ago
Reviewers:
berker.peksag, soltysh, rdmurray
CC:
barry, r.david.murray, devnull_psf.upfronthosting.co.za, berkerpeksag, maciej.szulik, gac
Visibility:
Public.

Patch Set 1 #

Total comments: 3

Patch Set 2 #

Patch Set 3 #

Patch Set 4 #

Total comments: 10

Patch Set 5 #

Total comments: 6

Patch Set 6 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/smtplib.rst View 1 2 3 4 5 1 chunk +3 lines, -2 lines 0 comments Download
Doc/whatsnew/3.5.rst View 1 2 3 4 5 2 chunks +8 lines, -0 lines 0 comments Download
Lib/smtplib.py View 1 2 3 4 5 9 chunks +19 lines, -14 lines 0 comments Download
Lib/test/test_smtplib.py View 1 2 3 4 5 1 chunk +20 lines, -0 lines 0 comments Download
Misc/ACKS View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6
berkerpeksag
http://bugs.python.org/review/16914/diff/7069/Doc/library/smtplib.rst File Doc/library/smtplib.rst (right): http://bugs.python.org/review/16914/diff/7069/Doc/library/smtplib.rst#newcode181 Doc/library/smtplib.rst:181: Set the debug output level. A value of 1 ...
6 years, 7 months ago #1
gac
http://bugs.python.org/review/16914/diff/7069/Lib/smtplib.py File Lib/smtplib.py (right): http://bugs.python.org/review/16914/diff/7069/Lib/smtplib.py#newcode288 Lib/smtplib.py:288: debugmsg = '[' + str(datetime.datetime.now().time()) + '] ' + ...
6 years, 7 months ago #2
berkerpeksag
http://bugs.python.org/review/16914/diff/14516/Doc/library/smtplib.rst File Doc/library/smtplib.rst (right): http://bugs.python.org/review/16914/diff/14516/Doc/library/smtplib.rst#newcode194 Doc/library/smtplib.rst:194: A value of 2 for *level* results in these ...
4 years, 4 months ago #3
maciej.szulik
Berker addressed your comments and replied to one of them. http://bugs.python.org/review/16914/diff/14516/Doc/library/smtplib.rst File Doc/library/smtplib.rst (right): http://bugs.python.org/review/16914/diff/14516/Doc/library/smtplib.rst#newcode194 ...
4 years, 4 months ago #4
r.david.murray
http://bugs.python.org/review/16914/diff/14626/Doc/whatsnew/3.5.rst File Doc/whatsnew/3.5.rst (right): http://bugs.python.org/review/16914/diff/14626/Doc/whatsnew/3.5.rst#newcode471 Doc/whatsnew/3.5.rst:471: * Additional loglevel (2) showing timestamps for debug messages ...
4 years, 4 months ago #5
maciej.szulik
4 years, 4 months ago #6
Review comments addressed.

http://bugs.python.org/review/16914/diff/14626/Doc/whatsnew/3.5.rst
File Doc/whatsnew/3.5.rst (right):

http://bugs.python.org/review/16914/diff/14626/Doc/whatsnew/3.5.rst#newcode471
Doc/whatsnew/3.5.rst:471: * Additional loglevel (2) showing timestamps for debug
messages in
On 2015/04/16 21:17:45, r.david.murray wrote:
> isn't it debuglevel?
> 
> Also, please add a bullet item in the porting section that the 'stderr' module
> level variable has been replaced by sys.stderr and that any test programs that
> patch smtplib.stderr to catch the debug output will need to be updated.

Done.

http://bugs.python.org/review/16914/diff/14626/Lib/smtplib.py
File Lib/smtplib.py (right):

http://bugs.python.org/review/16914/diff/14626/Lib/smtplib.py#newcode296
Lib/smtplib.py:296: self._print_debug('connect: to ', (host, port),
self.source_address)
On 2015/04/16 21:17:45, r.david.murray wrote:
> You added a stray space after 'to', and this same comment applies to all of
the
> other modified print statements: you introduced incorrect extra spaces.

Done.

http://bugs.python.org/review/16914/diff/14626/Lib/test/test_smtplib.py
File Lib/test/test_smtplib.py (right):

http://bugs.python.org/review/16914/diff/14626/Lib/test/test_smtplib.py#newco...
Lib/test/test_smtplib.py:137: # Issue 16914: new debuglevel for showing
timestamps in debug messages
On 2015/04/16 21:17:45, r.david.murray wrote:
> We don't generally comment the bug numbers for new features (unless there is
> important discussion in the bug).  (We do often for bug fixes because the bug
> report clarifies the reason for the test and fix.)  So I would just drop this
> comment.

Done.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+