Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(251528)

#16893: Create IDLE help.txt from Doc/library/idle.rst

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 7 months ago by zachary.ware
Modified:
3 years, 11 months ago
Reviewers:
nad
CC:
Georg, terry.reedy, ned.deily, serwy, eric.araujo, asvetlov, markroseman, irdb, docs_python.org, Todd.Rovito, devnull_psf.upfronthosting.co.za, Martin Panter, Zach Ware
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Total comments: 4

Patch Set 4 #

Patch Set 5 #

Patch Set 6 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/idlelib/EditorWindow.py View 1 2 3 4 5 4 chunks +10 lines, -2 lines 0 comments Download
Lib/idlelib/help.txt View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
Lib/idlelib/idle_test/htest.py View 1 2 3 4 5 2 chunks +7 lines, -7 lines 0 comments Download
Lib/idlelib/macosxSupport.py View 1 2 3 4 5 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 2
nad_acm.org
There are a couple of problems with the Makefile changes. I'm not convinced that the ...
6 years, 6 months ago #1
Zach Ware
6 years, 6 months ago #2
http://bugs.python.org/review/16893/diff/7400/Doc/Makefile
File Doc/Makefile (right):

http://bugs.python.org/review/16893/diff/7400/Doc/Makefile#newcode119
Doc/Makefile:119: idledoc: BULIDER = text
On 2013/02/18 07:55:09, ned.deily wrote:
> typo: BULIDER -> BUILDER
That's what I get for poor copying and not testing it myself.  Fixed.

http://bugs.python.org/review/16893/diff/7400/Doc/Makefile#newcode122
Doc/Makefile:122: @echo "Build finished; now copying build/text/library/idle.txt
to" \
On 2013/02/18 07:55:09, ned.deily wrote:
> The recipe lines in a Makefile rule have to begin with a TAB character, not
> spaces.  Likewise for the following two lines.
That would be the fault of my editor expanding tabs into spaces sometimes at
will, but I didn't know this anyway; thank you.  Fixed.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+