Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(40113)

#16832: Expose cache validity checking support in ABCMeta

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 8 months ago by ncoghlan
Modified:
5 years, 8 months ago
Reviewers:
pitrou, lukasz
CC:
PJ Eby, Nick Coghlan, AntoinePitrou, eric.araujo, r.david.murray, durban, lukasz.langa, devnull_psf.upfronthosting.co.za
Visibility:
Public.

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/abc.rst View 2 chunks +17 lines, -0 lines 4 comments Download
Lib/abc.py View 3 chunks +14 lines, -0 lines 0 comments Download
Lib/test/test_abc.py View 1 chunk +3 lines, -0 lines 1 comment Download

Messages

Total messages: 2
AntoinePitrou
http://bugs.python.org/review/16832/diff/8239/Doc/library/abc.rst File Doc/library/abc.rst (right): http://bugs.python.org/review/16832/diff/8239/Doc/library/abc.rst#newcode319 Doc/library/abc.rst:319: A function returning the current abstract base class cache ...
5 years, 8 months ago #1
lukasz.langa
5 years, 8 months ago #2
http://bugs.python.org/review/16832/diff/8239/Doc/library/abc.rst
File Doc/library/abc.rst (right):

http://bugs.python.org/review/16832/diff/8239/Doc/library/abc.rst#newcode319
Doc/library/abc.rst:319: A function returning the current abstract base class
cache token.
On 2013/05/25 18:30:41, AntoinePitrou wrote:
> You don't need to prefix the sentence with "A function returning...". Just
> "Return the current ABC cache token".

I hobgoblined this to be consistent with "A decorator", "A subclass", etc. But
you're right.

http://bugs.python.org/review/16832/diff/8239/Doc/library/abc.rst#newcode321
Doc/library/abc.rst:321: Returns an integer representing the current version of
the abstract
On 2013/05/25 18:30:41, AntoinePitrou wrote:
> I would say an "opaque integer identifying the current version of ...".

What does opaque mean in this context?
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+