Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2590)

#16764: Make zlib accept keyword-arguments

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 10 months ago by lukas.lueg
Modified:
1 year, 2 months ago
Reviewers:
storchaka+cpython, victor.stinner
CC:
haypo, ezio.melotti, lukas.lueg_gmail.com, devnull_psf.upfronthosting.co.za, Martin Panter, storchaka, matrixise, xiang.zhang
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/zlib.rst View 1 4 chunks +12 lines, -8 lines 1 comment Download
Lib/test/test_zlib.py View 1 3 chunks +29 lines, -4 lines 2 comments Download
Modules/clinic/zlibmodule.c.h View 1 5 chunks +11 lines, -9 lines 0 comments Download
Modules/zlibmodule.c View 1 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3
storchaka
http://bugs.python.org/review/16764/diff/18111/Doc/library/zlib.rst File Doc/library/zlib.rst (right): http://bugs.python.org/review/16764/diff/18111/Doc/library/zlib.rst#newcode132 Doc/library/zlib.rst:132: .. function:: decompress(data, wbits=15, bufsize=16384) Why not "wbits=MAX_WBITS, bufsize=DEF_BUF_SIZE"?
1 year, 2 months ago #1
haypo
https://bugs.python.org/review/16764/diff/18111/Lib/test/test_zlib.py File Lib/test/test_zlib.py (right): https://bugs.python.org/review/16764/diff/18111/Lib/test/test_zlib.py#newcode176 Lib/test/test_zlib.py:176: with self.assertRaises(TypeError): I don't think that this unit test ...
1 year, 2 months ago #2
storchaka
1 year, 2 months ago #3
https://bugs.python.org/review/16764/diff/18111/Lib/test/test_zlib.py
File Lib/test/test_zlib.py (right):

https://bugs.python.org/review/16764/diff/18111/Lib/test/test_zlib.py#newcode176
Lib/test/test_zlib.py:176: with self.assertRaises(TypeError):
On 2016/08/17 13:46:20, haypo wrote:
> I don't think that this unit test is mandatory. Another Python implementation
> (or a new version of Python) may decide to allow passing data by keyword.

Agreed.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7