Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(18)

#16748: Ensure test discovery doesn't break for modules testing C and Python implementations

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 3 months ago by zachary.ware
Modified:
7 years, 2 months ago
Reviewers:
storchaka
CC:
terry.reedy, ezio.melotti, eric.araujo, r.david.murray, cjerdonek, devnull_psf.upfronthosting.co.za, eric.snow, Zach Ware, storchaka
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 6

Patch Set 3 #

Patch Set 4 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/unittest/case.py View 1 2 3 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 2
storchaka_gmail.com
http://bugs.python.org/review/16748/diff/6966/Lib/test/test_genericpath.py File Lib/test/test_genericpath.py (right): http://bugs.python.org/review/16748/diff/6966/Lib/test/test_genericpath.py#newcode22 Lib/test/test_genericpath.py:22: pathmodule = genericpath It will be better move this ...
7 years, 3 months ago #1
Zach Ware
7 years, 3 months ago #2
http://bugs.python.org/review/16748/diff/6966/Lib/test/test_genericpath.py
File Lib/test/test_genericpath.py (right):

http://bugs.python.org/review/16748/diff/6966/Lib/test/test_genericpath.py#ne...
Lib/test/test_genericpath.py:22: pathmodule = genericpath
On 2013/01/03 11:45:12, storchaka wrote:
> It will be better move this assignment to TestGenericTest.

Could have sworn I had done this, but I think that was lost at some point when I
tried an idea that didn't work.  Done.

http://bugs.python.org/review/16748/diff/6966/Lib/test/test_genericpath.py#ne...
Lib/test/test_genericpath.py:285: pathmodule = None
On 2013/01/03 11:45:12, storchaka wrote:
> Remove this for better error message.

Also thought I had already done.  Now actually done.

http://bugs.python.org/review/16748/diff/6966/Lib/test/test_genericpath.py#ne...
Lib/test/test_genericpath.py:417: support.run_unittest(GenericTest)
On 2013/01/03 11:45:12, storchaka wrote:
> TestGenericTest

This I had just missed.  Thank you.  Done.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+