Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(53645)

#16694: Add pure Python operator module

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 10 months ago by zachary.ware
Modified:
6 years, 6 months ago
Reviewers:
storchaka, ezio.melotti
CC:
brett.cannon, rhettinger, jcea, AntoinePitrou, ezio.melotti, eric.araujo, Arfrever, alex, r.david.murray, meadori, devnull_psf.upfronthosting.co.za, Zach Ware, storchaka
Visibility:
Public.

Patch Set 1 #

Total comments: 21

Patch Set 2 #

Total comments: 8

Patch Set 3 #

Total comments: 8

Patch Set 4 #

Patch Set 5 #

Total comments: 2

Patch Set 6 #

Total comments: 4

Patch Set 7 #

Total comments: 13
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/hmac.py View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
Lib/operator.py View 1 2 3 4 5 6 1 chunk +414 lines, -0 lines 3 comments Download
Lib/test/test_operator.py View 1 2 3 4 5 6 4 chunks +230 lines, -218 lines 5 comments Download
Modules/_operator.c View 1 2 3 4 5 6 1 chunk +962 lines, -0 lines 0 comments Download
Modules/operator.c View 1 2 3 4 5 6 1 chunk +0 lines, -962 lines 0 comments Download
Modules/Setup.dist View 1 2 3 4 5 6 1 chunk +1 line, -1 line 5 comments Download
PCbuild/pythoncore.vcxproj View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
PCbuild/pythoncore.vcxproj.filters View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
PC/config.c View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
PC/VS9.0/pythoncore.vcproj View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14
storchaka_gmail.com
Oh, I forgot push "Publish All My Drafts" button. http://bugs.python.org/review/16694/diff/6826/Lib/operator.py File Lib/operator.py (right): http://bugs.python.org/review/16694/diff/6826/Lib/operator.py#newcode13 Lib/operator.py:13: ...
6 years, 10 months ago #1
storchaka_gmail.com
http://bugs.python.org/review/16694/diff/6858/Lib/operator.py File Lib/operator.py (right): http://bugs.python.org/review/16694/diff/6858/Lib/operator.py#newcode347 Lib/operator.py:347: except TypeError: It will be better to move the ...
6 years, 10 months ago #2
Zach Ware
Thanks for the reviews, Serhiy. I'll get the updated patch uploaded tonight when I get ...
6 years, 10 months ago #3
storchaka_gmail.com
http://bugs.python.org/review/16694/diff/6865/Lib/operator.py File Lib/operator.py (right): http://bugs.python.org/review/16694/diff/6865/Lib/operator.py#newcode30 Lib/operator.py:30: 'truediv', 'truth', 'xor'] You miss 'compare_digest'. http://bugs.python.org/review/16694/diff/6865/Lib/operator.py#newcode246 Lib/operator.py:246: return ...
6 years, 10 months ago #4
Zach Ware
http://bugs.python.org/review/16694/diff/6865/Lib/operator.py File Lib/operator.py (right): http://bugs.python.org/review/16694/diff/6865/Lib/operator.py#newcode30 Lib/operator.py:30: 'truediv', 'truth', 'xor'] On 2012/12/21 10:34:53, storchaka wrote: > ...
6 years, 10 months ago #5
ezio.melotti
http://bugs.python.org/review/16694/diff/6871/Lib/test/test_operator.py File Lib/test/test_operator.py (right): http://bugs.python.org/review/16694/diff/6871/Lib/test/test_operator.py#newcode40 Lib/test/test_operator.py:40: class OperatorTestCase(OperatorTestsMixin, unittest.TestCase): I think it's better if OperatorTestsMixin ...
6 years, 9 months ago #6
ezio.melotti
http://bugs.python.org/review/16694/diff/6871/Lib/test/test_operator.py File Lib/test/test_operator.py (right): http://bugs.python.org/review/16694/diff/6871/Lib/test/test_operator.py#newcode40 Lib/test/test_operator.py:40: class OperatorTestCase(OperatorTestsMixin, unittest.TestCase): See http://bugs.python.org/issue16748
6 years, 9 months ago #7
ezio.melotti
http://bugs.python.org/review/16694/diff/6956/Lib/test/test_operator.py File Lib/test/test_operator.py (right): http://bugs.python.org/review/16694/diff/6956/Lib/test/test_operator.py#newcode36 Lib/test/test_operator.py:36: class PyTest(unittest.TestCase): Note that you don't necessarily need these ...
6 years, 9 months ago #8
Zach Ware
http://bugs.python.org/review/16694/diff/6956/Lib/test/test_operator.py File Lib/test/test_operator.py (right): http://bugs.python.org/review/16694/diff/6956/Lib/test/test_operator.py#newcode36 Lib/test/test_operator.py:36: class PyTest(unittest.TestCase): On 2013/01/02 01:39:42, ezio.melotti wrote: > Note ...
6 years, 9 months ago #9
ezio.melotti
http://bugs.python.org/review/16694/diff/7253/Lib/test/test_operator.py File Lib/test/test_operator.py (right): http://bugs.python.org/review/16694/diff/7253/Lib/test/test_operator.py#newcode440 Lib/test/test_operator.py:440: self.module.length_hint(X(LookupError)) As suggested by Antoine, you could do module ...
6 years, 6 months ago #10
Zach Ware
Herein are replies to Ezio's last review, and a few comments about things I found ...
6 years, 6 months ago #11
ezio.melotti
http://bugs.python.org/review/16694/diff/7253/Modules/Setup.dist File Modules/Setup.dist (right): http://bugs.python.org/review/16694/diff/7253/Modules/Setup.dist#newcode116 Modules/Setup.dist:116: _operator _operator.c # operator.add() and similar goodies On 2013/04/15 ...
6 years, 6 months ago #12
Zach Ware
http://bugs.python.org/review/16694/diff/7253/Modules/Setup.dist File Modules/Setup.dist (right): http://bugs.python.org/review/16694/diff/7253/Modules/Setup.dist#newcode116 Modules/Setup.dist:116: _operator _operator.c # operator.add() and similar goodies On 2013/04/15 ...
6 years, 6 months ago #13
ezio.melotti
6 years, 6 months ago #14
http://bugs.python.org/review/16694/diff/7253/Modules/Setup.dist
File Modules/Setup.dist (right):

http://bugs.python.org/review/16694/diff/7253/Modules/Setup.dist#newcode116
Modules/Setup.dist:116: _operator _operator.c	        # operator.add() and
similar goodies
On 2013/04/15 17:56:34, zach.ware wrote:
> On 2013/04/15 17:47:16, ezio.melotti wrote:
> > On 2013/04/15 17:30:21, zach.ware wrote:
> > > On 2013/04/14 18:49:05, ezio.melotti wrote:
> > > > Tab!
> > > 
> > > Is this meant to be a tab or not be a tab?  It is a tab originally, and
> there
> > > are tabs in all the other lines in this section too.  This change was a
> simple
> > > s/operator/_operator/ operation.
> > 
> > I thought we got rid of all tabs in the C files, not sure why these are here
> > then (also rietveld only highlighted this one -- maybe because it's the only
> > line that changed.)
> 
> Interestingly, there is originally a mix of tab and spaces in this section
and,
> in fact, within this line!  The unadulterated line (with \t = tab and - =
space)
> is "operator.c-operator.c\t--------#-operator.add()-and-similar-goodies"
> 
> Is it ok to leave the change at simply s/operator/_operator/ and leave the
> whitespace of Modules/Setup.dist for another issue?

Yes.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+