Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4)

#16692: Support TLS 1.1 and TLS 1.2

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 3 months ago by solipsis
Modified:
7 years, 2 months ago
Reviewers:
lists, merwok, maker.py
CC:
jcea, AntoinePitrou, giampaolo.rodola, christian.heimes, Arfrever, maker, devnull_psf.upfronthosting.co.za, tmnichols_gmail.com, wmark_hurrikane.de, wes.turner_gmail.com
Visibility:
Public.

Patch Set 1 #

Total comments: 10

Patch Set 2 #

Total comments: 4

Patch Set 3 #

Patch Set 4 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/ssl.rst View 1 2 3 4 chunks +45 lines, -10 lines 0 comments Download
Doc/whatsnew/3.4.rst View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
Lib/ssl.py View 1 2 3 3 chunks +11 lines, -2 lines 0 comments Download
Lib/test/test_ssl.py View 1 2 3 5 chunks +53 lines, -20 lines 0 comments Download
Misc/NEWS View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
Modules/_ssl.c View 1 2 3 5 chunks +27 lines, -0 lines 0 comments Download
setup.py View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6
christian.heimes
http://bugs.python.org/review/16692/diff/7338/Modules/_ssl.c File Modules/_ssl.c (right): http://bugs.python.org/review/16692/diff/7338/Modules/_ssl.c#newcode81 Modules/_ssl.c:81: PY_SSL_VERSION_TLS1, C89 doesn't allow trailing comma in enums (although ...
7 years, 3 months ago #1
christian.heimes
http://bugs.python.org/review/16692/diff/7338/Doc/library/ssl.rst File Doc/library/ssl.rst (right): http://bugs.python.org/review/16692/diff/7338/Doc/library/ssl.rst#newcode30 Doc/library/ssl.rst:30: openssl verision 1.0.1. Typo: verision -> version http://bugs.python.org/review/16692/diff/7338/Doc/library/ssl.rst#newcode411 Doc/library/ssl.rst:411: ...
7 years, 3 months ago #2
eric.araujo
http://bugs.python.org/review/16692/diff/7338/Misc/NEWS File Misc/NEWS (right): http://bugs.python.org/review/16692/diff/7338/Misc/NEWS#newcode972 Misc/NEWS:972: - Issue #17028: Allowed Python arguments to be supplied ...
7 years, 3 months ago #3
maker.py_gmail.com
On 2013/02/13 16:45:50, eric.araujo wrote: > http://bugs.python.org/review/16692/diff/7338/Misc/NEWS > File Misc/NEWS (right): > > http://bugs.python.org/review/16692/diff/7338/Misc/NEWS#newcode972 > ...
7 years, 3 months ago #4
maker.py_gmail.com
http://bugs.python.org/review/16692/diff/7338/Doc/library/ssl.rst File Doc/library/ssl.rst (right): http://bugs.python.org/review/16692/diff/7338/Doc/library/ssl.rst#newcode30 Doc/library/ssl.rst:30: openssl verision 1.0.1. On 2013/02/13 16:29:59, christian.heimes wrote: > ...
7 years, 3 months ago #5
pitrou_free.fr
7 years, 2 months ago #6
The patch looks mostly good. A couple of small comments below.

http://bugs.python.org/review/16692/diff/7657/Doc/library/ssl.rst
File Doc/library/ssl.rst (right):

http://bugs.python.org/review/16692/diff/7657/Doc/library/ssl.rst#newcode462
Doc/library/ssl.rst:462: with :const:`PROCOL_SSLv23`. It prevents the peers from
choosing TLSv1.1 as
Typo: PROCOL -> PROTOCOL

http://bugs.python.org/review/16692/diff/7657/Doc/library/ssl.rst#newcode470
Doc/library/ssl.rst:470: with :const:`PROCOL_SSLv23`. It prevents the peers from
choosing TLSv1.2 as
Same as above.

http://bugs.python.org/review/16692/diff/7657/Lib/test/test_ssl.py
File Lib/test/test_ssl.py (right):

http://bugs.python.org/review/16692/diff/7657/Lib/test/test_ssl.py#newcode29
Lib/test/test_ssl.py:29: PROTOCOLS.extend(getattr(ssl, proto) for proto in
optional_protos if hasattr(ssl, proto))
I realize we could simply write:

  PROTOCOLS = sorted(ssl._PROTOCOL_NAMES)

no?

http://bugs.python.org/review/16692/diff/7657/Modules/_ssl.c
File Modules/_ssl.c (right):

http://bugs.python.org/review/16692/diff/7657/Modules/_ssl.c#newcode84
Modules/_ssl.c:84: PY_SSL_VERSION_TLS1_2,
Beware the trailing comma.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+