Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(30)

#16597: file descriptor not being closed with context manager on IOError when device is full

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 2 months ago by johnjohn.tedro
Modified:
7 years, 2 months ago
Reviewers:
benjamin
CC:
jcea, AntoinePitrou, christian.heimes, Benjamin Peterson, stutzbach, Arfrever, asvetlov, devnull_psf.upfronthosting.co.za, hynek, storchaka, johnjohn.tedro_gmail.com
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 1

Patch Set 3 #

Patch Set 4 #

Patch Set 5 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/_pyio.py View 1 2 3 4 2 chunks +8 lines, -4 lines 0 comments Download
Lib/test/test_io.py View 1 2 3 4 4 chunks +27 lines, -0 lines 0 comments Download
Modules/_io/bufferedio.c View 1 2 3 4 2 chunks +17 lines, -5 lines 0 comments Download
Modules/_io/textio.c View 1 2 3 4 1 chunk +16 lines, -4 lines 0 comments Download

Messages

Total messages: 1
Benjamin Peterson
7 years, 2 months ago #1
LGTM aside from a nit.

http://bugs.python.org/review/16597/diff/6732/Modules/_io/bufferedio.c
File Modules/_io/bufferedio.c (right):

http://bugs.python.org/review/16597/diff/6732/Modules/_io/bufferedio.c#newcod...
Modules/_io/bufferedio.c:489: PyObject *exc = NULL, *val, *tb;
Put this with the first line of variable declarations.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+