Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(76180)

Unified Diff: Lib/test/test_xdrlib.py

Issue 16510: Using appropriate checks in tests
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Lib/test/test_with.py ('k') | Lib/test/test_xmlrpc.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
--- a/Lib/test/test_xdrlib.py Fri Feb 07 17:53:13 2014 +0100
+++ b/Lib/test/test_xdrlib.py Fri Feb 07 23:40:05 2014 +0200
@@ -32,15 +32,15 @@
self.assertEqual(up.unpack_int(), 42)
self.assertEqual(up.unpack_int(), -17)
self.assertEqual(up.unpack_uint(), 9)
- self.assertTrue(up.unpack_bool() is True)
+ self.assertIs(up.unpack_bool(), True)
# remember position
pos = up.get_position()
- self.assertTrue(up.unpack_bool() is False)
+ self.assertIs(up.unpack_bool(), False)
# rewind and unpack again
up.set_position(pos)
- self.assertTrue(up.unpack_bool() is False)
+ self.assertIs(up.unpack_bool(), False)
self.assertEqual(up.unpack_uhyper(), 45)
self.assertAlmostEqual(up.unpack_float(), 1.9)
« no previous file with comments | « Lib/test/test_with.py ('k') | Lib/test/test_xmlrpc.py » ('j') | no next file with comments »

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+