Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(267903)

Unified Diff: Lib/test/test_uuid.py

Issue 16510: Using appropriate checks in tests
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Lib/test/test_unicode_file.py ('k') | Lib/test/test_weakset.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
--- a/Lib/test/test_uuid.py Fri Feb 07 17:53:13 2014 +0100
+++ b/Lib/test/test_uuid.py Fri Feb 07 23:40:05 2014 +0200
@@ -296,8 +296,8 @@
def check_node(self, node, source):
message = "%012x is not an RFC 4122 node ID" % node
- self.assertTrue(0 < node, message)
- self.assertTrue(node < (1 << 48), message)
+ self.assertGreater(node, 0, message)
+ self.assertLess(node, 1 << 48, message)
TestUUID.source2node[source] = node
if TestUUID.last_node:
@@ -334,7 +334,7 @@
node = uuid._random_getnode()
# Least significant bit of first octet must be set.
self.assertTrue(node & 0x010000000000)
- self.assertTrue(node < (1 << 48))
+ self.assertLess(node, 1 << 48)
@unittest.skipUnless(os.name == 'posix', 'requires Posix')
@unittest.skipUnless(importable('ctypes'), 'requires ctypes')
« no previous file with comments | « Lib/test/test_unicode_file.py ('k') | Lib/test/test_weakset.py » ('j') | no next file with comments »

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+