Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(251492)

Unified Diff: Lib/test/test_ssl.py

Issue 16510: Using appropriate checks in tests
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Lib/test/test_socket.py ('k') | Lib/test/test_strptime.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
--- a/Lib/test/test_ssl.py Fri Feb 07 17:53:13 2014 +0100
+++ b/Lib/test/test_ssl.py Fri Feb 07 23:40:05 2014 +0200
@@ -2639,7 +2639,7 @@
context.options |= ssl.OP_NO_COMPRESSION
stats = server_params_test(context, context,
chatty=True, connectionchatty=True)
- self.assertIs(stats['compression'], None)
+ self.assertIsNone(stats['compression'])
def test_dh_params(self):
# Check we can get a connection with ephemeral Diffie-Hellman
@@ -2660,7 +2660,7 @@
context.load_cert_chain(CERTFILE)
stats = server_params_test(context, context,
chatty=True, connectionchatty=True)
- self.assertIs(stats['client_npn_protocol'], None)
+ self.assertIsNone(stats['client_npn_protocol'])
@unittest.skipUnless(ssl.HAS_NPN, "NPN support needed for this test")
def test_npn_protocols(self):
« no previous file with comments | « Lib/test/test_socket.py ('k') | Lib/test/test_strptime.py » ('j') | no next file with comments »

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+