Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(154437)

Unified Diff: Lib/test/test_selectors.py

Issue 16510: Using appropriate checks in tests
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Lib/test/test_sax.py ('k') | Lib/test/test_shutil.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
--- a/Lib/test/test_selectors.py Fri Feb 07 17:53:13 2014 +0100
+++ b/Lib/test/test_selectors.py Fri Feb 07 23:40:05 2014 +0200
@@ -237,7 +237,7 @@
result = s.select()
for key, events in result:
- self.assertTrue(isinstance(key, selectors.SelectorKey))
+ self.assertIsInstance(key, selectors.SelectorKey)
self.assertTrue(events)
self.assertFalse(events & ~(selectors.EVENT_READ |
selectors.EVENT_WRITE))
@@ -263,7 +263,7 @@
if hasattr(s, 'fileno'):
fd = s.fileno()
- self.assertTrue(isinstance(fd, int))
+ self.assertIsInstance(fd, int)
self.assertGreaterEqual(fd, 0)
def test_selector(self):
« no previous file with comments | « Lib/test/test_sax.py ('k') | Lib/test/test_shutil.py » ('j') | no next file with comments »

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+