Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(96115)

Unified Diff: Lib/test/test_pyexpat.py

Issue 16510: Using appropriate checks in tests
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Lib/test/test_pulldom.py ('k') | Lib/test/test_re.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
--- a/Lib/test/test_pyexpat.py Fri Feb 07 17:53:13 2014 +0100
+++ b/Lib/test/test_pyexpat.py Fri Feb 07 23:40:05 2014 +0200
@@ -285,7 +285,7 @@
self.assertEqual(len(L), 6)
for entry in L:
# L should have the same string repeated over and over.
- self.assertTrue(tag is entry)
+ self.assertIs(tag, entry)
def test_issue9402(self):
# create an ExternalEntityParserCreate with buffer text
@@ -432,7 +432,7 @@
self.parser.CurrentByteIndex,
self.parser.CurrentLineNumber,
self.parser.CurrentColumnNumber)
- self.assertTrue(self.upto < len(self.expected_list),
+ self.assertLess(self.upto, len(self.expected_list),
'too many parser events')
expected = self.expected_list[self.upto]
self.assertEqual(pos, expected,
« no previous file with comments | « Lib/test/test_pulldom.py ('k') | Lib/test/test_re.py » ('j') | no next file with comments »

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+