Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(198599)

Unified Diff: Lib/test/test_memoryview.py

Issue 16510: Using appropriate checks in tests
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Lib/test/test_logging.py ('k') | Lib/test/test_minidom.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
--- a/Lib/test/test_memoryview.py Fri Feb 07 17:53:13 2014 +0100
+++ b/Lib/test/test_memoryview.py Fri Feb 07 23:40:05 2014 +0200
@@ -237,7 +237,7 @@
b = m = o = None
# The cycle must be broken
gc.collect()
- self.assertTrue(wr() is None, wr())
+ self.assertIsNone(wr())
# This exercises memory_clear().
m = MyView(tp(b'abc'))
@@ -248,7 +248,7 @@
m = o = None
# The cycle must be broken
gc.collect()
- self.assertTrue(wr() is None, wr())
+ self.assertIsNone(wr())
def _check_released(self, m, tp):
check = self.assertRaisesRegex(ValueError, "released")
@@ -349,7 +349,7 @@
self.assertIs(wr(), m)
del m
test.support.gc_collect()
- self.assertIs(wr(), None)
+ self.assertIsNone(wr())
self.assertIs(L[0], b)
def test_reversed(self):
« no previous file with comments | « Lib/test/test_logging.py ('k') | Lib/test/test_minidom.py » ('j') | no next file with comments »

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+