Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(197612)

Unified Diff: Lib/test/test_logging.py

Issue 16510: Using appropriate checks in tests
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Lib/test/test_kqueue.py ('k') | Lib/test/test_memoryview.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
--- a/Lib/test/test_logging.py Fri Feb 07 17:53:13 2014 +0100
+++ b/Lib/test/test_logging.py Fri Feb 07 23:40:05 2014 +0200
@@ -3013,7 +3013,7 @@
msg = self.next_message()
self.que_logger.warning(msg)
data = self.queue.get_nowait()
- self.assertTrue(isinstance(data, logging.LogRecord))
+ self.assertIsInstance(data, logging.LogRecord)
self.assertEqual(data.name, self.que_logger.name)
self.assertEqual((data.msg, data.args), (msg, None))
« no previous file with comments | « Lib/test/test_kqueue.py ('k') | Lib/test/test_memoryview.py » ('j') | no next file with comments »

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+