Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(169852)

Unified Diff: Lib/test/test_kqueue.py

Issue 16510: Using appropriate checks in tests
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Lib/test/test_json/test_decode.py ('k') | Lib/test/test_logging.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
--- a/Lib/test/test_kqueue.py Fri Feb 07 17:53:13 2014 +0100
+++ b/Lib/test/test_kqueue.py Fri Feb 07 23:40:05 2014 +0200
@@ -16,8 +16,8 @@
class TestKQueue(unittest.TestCase):
def test_create_queue(self):
kq = select.kqueue()
- self.assertTrue(kq.fileno() > 0, kq.fileno())
- self.assertTrue(not kq.closed)
+ self.assertGreater(kq.fileno(), 0)
+ self.assertFalse(kq.closed)
kq.close()
self.assertTrue(kq.closed)
self.assertRaises(ValueError, kq.fileno)
« no previous file with comments | « Lib/test/test_json/test_decode.py ('k') | Lib/test/test_logging.py » ('j') | no next file with comments »

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+