Lib/test/test_json/test_decode.py - Issue 16510: Using appropriate checks in tests

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Unified Diff: Lib/test/test_json/test_decode.py

Issue 16510: Using appropriate checks in tests

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

--- a/Lib/test/test_json/test_decode.py Fri Feb 07 17:53:13 2014 +0100

+++ b/Lib/test/test_json/test_decode.py Fri Feb 07 23:40:05 2014 +0200

@@ -7,12 +7,12 @@

class TestDecode:

def test_decimal(self):

rval = self.loads('1.1', parse_float=decimal.Decimal)

- self.assertTrue(isinstance(rval, decimal.Decimal))

+ self.assertIsInstance(rval, decimal.Decimal)

self.assertEqual(rval, decimal.Decimal('1.1'))

def test_float(self):

rval = self.loads('1', parse_int=float)

- self.assertTrue(isinstance(rval, float))

+ self.assertIsInstance(rval, float)

self.assertEqual(rval, 1.0)

def test_empty_objects(self):

« no previous file with comments | « Lib/test/test_itertools.py ('k') | Lib/test/test_kqueue.py » ('j') | no next file with comments »