Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(194799)

Unified Diff: Lib/test/test_iter.py

Issue 16510: Using appropriate checks in tests
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Lib/test/test_inspect.py ('k') | Lib/test/test_itertools.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
--- a/Lib/test/test_iter.py Fri Feb 07 17:53:13 2014 +0100
+++ b/Lib/test/test_iter.py Fri Feb 07 23:40:05 2014 +0200
@@ -81,7 +81,7 @@
# Cannot assert type equality because dict iterators unpickle as list
# iterators.
# self.assertEqual(type(itorg), type(it))
- self.assertTrue(isinstance(it, collections.abc.Iterator))
+ self.assertIsInstance(it, collections.abc.Iterator)
self.assertEqual(list(it), seq)
it = pickle.loads(d)
@@ -102,7 +102,7 @@
seq = list(range(10))
it = iter(seq)
it2 = iter(it)
- self.assertTrue(it is it2)
+ self.assertIs(it, it2)
# Test that for loops over iterators work
def test_iter_for_loop(self):
« no previous file with comments | « Lib/test/test_inspect.py ('k') | Lib/test/test_itertools.py » ('j') | no next file with comments »

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+