Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(167754)

Unified Diff: Lib/test/test_filecmp.py

Issue 16510: Using appropriate checks in tests
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Lib/test/test_faulthandler.py ('k') | Lib/test/test_fnmatch.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
--- a/Lib/test/test_filecmp.py Fri Feb 07 17:53:13 2014 +0100
+++ b/Lib/test/test_filecmp.py Fri Feb 07 23:40:05 2014 +0200
@@ -82,10 +82,10 @@
self.assertIn('.hg', filecmp.DEFAULT_IGNORES)
def test_cmpfiles(self):
- self.assertTrue(filecmp.cmpfiles(self.dir, self.dir, ['file']) ==
+ self.assertEqual(filecmp.cmpfiles(self.dir, self.dir, ['file']),
(['file'], [], []),
"Comparing directory to itself fails")
- self.assertTrue(filecmp.cmpfiles(self.dir, self.dir_same, ['file']) ==
+ self.assertEqual(filecmp.cmpfiles(self.dir, self.dir_same, ['file']),
(['file'], [], []),
"Comparing directory to same fails")
@@ -120,7 +120,8 @@
else:
self.assertEqual([d.left_list, d.right_list],[['file'], ['file']])
self.assertEqual(d.common, ['file'])
- self.assertTrue(d.left_only == d.right_only == [])
+ self.assertEqual(d.left_only, [])
+ self.assertEqual(d.left_only, [])
self.assertEqual(d.same_files, ['file'])
self.assertEqual(d.diff_files, [])
« no previous file with comments | « Lib/test/test_faulthandler.py ('k') | Lib/test/test_fnmatch.py » ('j') | no next file with comments »

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+