Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(79409)

Unified Diff: Lib/test/test_concurrent_futures.py

Issue 16510: Using appropriate checks in tests
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Lib/test/test_complex.py ('k') | Lib/test/test_configparser.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
--- a/Lib/test/test_concurrent_futures.py Fri Feb 07 17:53:13 2014 +0100
+++ b/Lib/test/test_concurrent_futures.py Fri Feb 07 23:40:05 2014 +0200
@@ -655,8 +655,7 @@
CANCELLED_FUTURE.exception, timeout=0)
self.assertRaises(futures.CancelledError,
CANCELLED_AND_NOTIFIED_FUTURE.exception, timeout=0)
- self.assertTrue(isinstance(EXCEPTION_FUTURE.exception(timeout=0),
- OSError))
+ self.assertIsInstance(EXCEPTION_FUTURE.exception(timeout=0), OSError)
self.assertEqual(SUCCESSFUL_FUTURE.exception(timeout=0), None)
def test_exception_with_success(self):
@@ -672,7 +671,7 @@
t = threading.Thread(target=notification)
t.start()
- self.assertTrue(isinstance(f1.exception(timeout=5), OSError))
+ self.assertIsInstance(f1.exception(timeout=5), OSError)
@test.support.reap_threads
def test_main():
« no previous file with comments | « Lib/test/test_complex.py ('k') | Lib/test/test_configparser.py » ('j') | no next file with comments »

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+