Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(263386)

Unified Diff: Lib/test/test_capi.py

Issue 16510: Using appropriate checks in tests
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Lib/test/test_bz2.py ('k') | Lib/test/test_cmd_line.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
--- a/Lib/test/test_capi.py Fri Feb 07 17:53:13 2014 +0100
+++ b/Lib/test/test_capi.py Fri Feb 07 23:40:05 2014 +0200
@@ -35,7 +35,7 @@
def test_instancemethod(self):
inst = InstanceMethod()
self.assertEqual(id(inst), inst.id())
- self.assertTrue(inst.testfunction() is inst)
+ self.assertIs(inst.testfunction(), inst)
self.assertEqual(inst.testfunction.__doc__, testfunction.__doc__)
self.assertEqual(InstanceMethod.testfunction.__doc__, testfunction.__doc__)
@@ -174,7 +174,7 @@
if context and not context.event.is_set():
continue
count += 1
- self.assertTrue(count < 10000,
+ self.assertLess(count, 10000,
"timeout waiting for %i callbacks, got %i"%(n, len(l)))
if False and support.verbose:
print("(%i)"%(len(l),))
« no previous file with comments | « Lib/test/test_bz2.py ('k') | Lib/test/test_cmd_line.py » ('j') | no next file with comments »

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+