Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(87859)

Unified Diff: Lib/test/test_ast.py

Issue 16510: Using appropriate checks in tests
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Lib/test/test_abc.py ('k') | Lib/test/test_asyncore.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
--- a/Lib/test/test_ast.py Fri Feb 07 17:53:13 2014 +0100
+++ b/Lib/test/test_ast.py Fri Feb 07 23:40:05 2014 +0200
@@ -197,9 +197,9 @@
if isinstance(ast_node, (ast.expr, ast.stmt, ast.excepthandler)):
node_pos = (ast_node.lineno, ast_node.col_offset)
if reverse_check:
- self.assertTrue(node_pos <= parent_pos)
+ self.assertLessEqual(node_pos, parent_pos)
else:
- self.assertTrue(node_pos >= parent_pos)
+ self.assertGreaterEqual(node_pos, parent_pos)
parent_pos = (ast_node.lineno, ast_node.col_offset)
for name in ast_node._fields:
value = getattr(ast_node, name)
« no previous file with comments | « Lib/test/test_abc.py ('k') | Lib/test/test_asyncore.py » ('j') | no next file with comments »

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+