Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(75015)

Unified Diff: Lib/test/test_abc.py

Issue 16510: Using appropriate checks in tests
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Lib/test/pickletester.py ('k') | Lib/test/test_ast.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
--- a/Lib/test/test_abc.py Fri Feb 07 17:53:13 2014 +0100
+++ b/Lib/test/test_abc.py Fri Feb 07 23:40:05 2014 +0200
@@ -299,14 +299,14 @@
class B:
pass
b = B()
- self.assertFalse(isinstance(b, A))
- self.assertFalse(isinstance(b, (A,)))
+ self.assertNotIsInstance(b, A)
+ self.assertNotIsInstance(b, (A,))
token_old = abc.get_cache_token()
A.register(B)
token_new = abc.get_cache_token()
self.assertNotEqual(token_old, token_new)
- self.assertTrue(isinstance(b, A))
- self.assertTrue(isinstance(b, (A,)))
+ self.assertIsInstance(b, A)
+ self.assertIsInstance(b, (A,))
def test_registration_builtins(self):
class A(metaclass=abc.ABCMeta):
« no previous file with comments | « Lib/test/pickletester.py ('k') | Lib/test/test_ast.py » ('j') | no next file with comments »

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+