Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7)

#16406: move the "Uploading Packages" section to distutils/packageindex.rst

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 2 months ago by chris.jerdonek
Modified:
7 years, 1 month ago
Reviewers:
ezio.melotti, merwok
CC:
cjerdonek, tarek_ziade.org
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Patch Set 4 #

Total comments: 13
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/distutils/index.rst View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
Doc/distutils/packageindex.rst View 1 2 3 3 chunks +115 lines, -6 lines 5 comments Download
Doc/distutils/setupscript.rst View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
Doc/distutils/uploading.rst View 1 2 3 1 chunk +2 lines, -75 lines 8 comments Download

Messages

Total messages: 9
ezio.melotti
http://bugs.python.org/review/16406/diff/7470/Doc/distutils/uploading.rst File Doc/distutils/uploading.rst (right): http://bugs.python.org/review/16406/diff/7470/Doc/distutils/uploading.rst#newcode7 Doc/distutils/uploading.rst:7: The contents of this page have moved to the ...
7 years, 1 month ago #1
cjerdonek
http://bugs.python.org/review/16406/diff/7470/Doc/distutils/uploading.rst File Doc/distutils/uploading.rst (right): http://bugs.python.org/review/16406/diff/7470/Doc/distutils/uploading.rst#newcode7 Doc/distutils/uploading.rst:7: The contents of this page have moved to the ...
7 years, 1 month ago #2
eric.araujo
http://bugs.python.org/review/16406/diff/7470/Doc/distutils/packageindex.rst File Doc/distutils/packageindex.rst (right): http://bugs.python.org/review/16406/diff/7470/Doc/distutils/packageindex.rst#newcode73 Doc/distutils/packageindex.rst:73: I assume this is just moved from the former ...
7 years, 1 month ago #3
eric.araujo
http://bugs.python.org/review/16406/diff/7470/Doc/distutils/packageindex.rst File Doc/distutils/packageindex.rst (right): http://bugs.python.org/review/16406/diff/7470/Doc/distutils/packageindex.rst#newcode73 Doc/distutils/packageindex.rst:73: Alright, you said so in the bug log. Thanks. ...
7 years, 1 month ago #4
cjerdonek
http://bugs.python.org/review/16406/diff/7470/Doc/distutils/packageindex.rst File Doc/distutils/packageindex.rst (right): http://bugs.python.org/review/16406/diff/7470/Doc/distutils/packageindex.rst#newcode180 Doc/distutils/packageindex.rst:180: the server to display a home page for the ...
7 years, 1 month ago #5
eric.araujo
http://bugs.python.org/review/16406/diff/7470/Doc/distutils/uploading.rst File Doc/distutils/uploading.rst (right): http://bugs.python.org/review/16406/diff/7470/Doc/distutils/uploading.rst#newcode7 Doc/distutils/uploading.rst:7: The contents of this page have moved to the ...
7 years, 1 month ago #6
cjerdonek
http://bugs.python.org/review/16406/diff/7470/Doc/distutils/uploading.rst File Doc/distutils/uploading.rst (right): http://bugs.python.org/review/16406/diff/7470/Doc/distutils/uploading.rst#newcode7 Doc/distutils/uploading.rst:7: The contents of this page have moved to the ...
7 years, 1 month ago #7
cjerdonek
http://bugs.python.org/review/16406/diff/7470/Doc/distutils/uploading.rst File Doc/distutils/uploading.rst (right): http://bugs.python.org/review/16406/diff/7470/Doc/distutils/uploading.rst#newcode7 Doc/distutils/uploading.rst:7: The contents of this page have moved to the ...
7 years, 1 month ago #8
ezio.melotti
7 years, 1 month ago #9
I wrote this comment yesterday, but apparently forgot to submit it, so here it
is.

http://bugs.python.org/review/16406/diff/7470/Doc/distutils/uploading.rst
File Doc/distutils/uploading.rst (right):

http://bugs.python.org/review/16406/diff/7470/Doc/distutils/uploading.rst#new...
Doc/distutils/uploading.rst:7: The contents of this page have moved to the
section :ref:`package-index`.
On 2013/02/27 04:12:14, cjerdonek wrote:
> On 2013/02/27 04:00:40, ezio.melotti wrote:
> > Shouldn't this be :ref:`package-upload`?  :ref:`package-index` will link to
> the
> > beginning of the page.
> 
> Thanks a lot for taking a look at this. This was intentional because the
content
> was moved to two sections of the package-index section: package-upload and
> package-display. I don't have a strong opinion about this. Another option is
to
> list both sections "package-upload" and "package-display". Do you have a
> preference?

Two or even three links might be a good solution (something like "The contents
of this page have moved to the sections :ref:`package-upload` and
:ref:`package-display` of the :ref:`package-index` page.").

The package-index page seems short enough to fit in 1-2 screens, so even if only
a single link is provided, it shouldn't take long for people to find what they
are looking for.  If you decide to keep a single link, maybe replace "section"
with "page".
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+