Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(194508)

#16331: Add a version switcher to python docs site

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 1 month ago by yselivanov
Modified:
7 years, 1 month ago
Reviewers:
ezio.melotti
CC:
loewis, Georg, rhettinger, ezio.melotti, eric.araujo, r.david.murray, cjerdonek, docs_python.org, Yury Selivanov
Visibility:
Public.

Patch Set 1 #

Total comments: 11
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/conf.py View 1 chunk +1 line, -1 line 4 comments Download
Doc/tools/sphinxext/layout.html View 1 chunk +8 lines, -2 lines 3 comments Download
Doc/tools/sphinxext/static/version_switch.js View 1 chunk +87 lines, -0 lines 4 comments Download

Messages

Total messages: 6
ezio.melotti
http://bugs.python.org/review/16331/diff/6400/Doc/conf.py File Doc/conf.py (right): http://bugs.python.org/review/16331/diff/6400/Doc/conf.py#newcode72 Doc/conf.py:72: html_short_title = 'Documentation' I would leave this unchanged, in ...
7 years, 1 month ago #1
Yury.Selivanov
http://bugs.python.org/review/16331/diff/6400/Doc/conf.py File Doc/conf.py (right): http://bugs.python.org/review/16331/diff/6400/Doc/conf.py#newcode72 Doc/conf.py:72: html_short_title = 'Documentation' On 2012/10/26 19:48:52, ezio.melotti wrote: > ...
7 years, 1 month ago #2
Yury.Selivanov
http://bugs.python.org/review/16331/diff/6400/Doc/tools/sphinxext/static/version_switch.js File Doc/tools/sphinxext/static/version_switch.js (right): http://bugs.python.org/review/16331/diff/6400/Doc/tools/sphinxext/static/version_switch.js#newcode4 Doc/tools/sphinxext/static/version_switch.js:4: var all_versions = ['3.4', '3.3', '3.2', '3.1', '3.0', On ...
7 years, 1 month ago #3
Yury.Selivanov
http://bugs.python.org/review/16331/diff/6400/Doc/tools/sphinxext/layout.html File Doc/tools/sphinxext/layout.html (right): http://bugs.python.org/review/16331/diff/6400/Doc/tools/sphinxext/layout.html#newcode7 Doc/tools/sphinxext/layout.html:7: <span id="version_switcher">{{ release }}</span> On 2012/10/26 19:48:52, ezio.melotti wrote: ...
7 years, 1 month ago #4
ezio.melotti
http://bugs.python.org/review/16331/diff/6400/Doc/conf.py File Doc/conf.py (right): http://bugs.python.org/review/16331/diff/6400/Doc/conf.py#newcode72 Doc/conf.py:72: html_short_title = 'Documentation' On 2012/10/26 19:53:25, yselivanov wrote: > ...
7 years, 1 month ago #5
Yury.Selivanov
7 years, 1 month ago #6
http://bugs.python.org/review/16331/diff/6400/Doc/conf.py
File Doc/conf.py (right):

http://bugs.python.org/review/16331/diff/6400/Doc/conf.py#newcode72
Doc/conf.py:72: html_short_title = 'Documentation'
On 2012/10/26 20:34:11, ezio.melotti wrote:
> On 2012/10/26 19:53:25, yselivanov wrote:
> > On 2012/10/26 19:48:52, ezio.melotti wrote:
> > > I would leave this unchanged, in order to have the right title when js is
> not
> > > available.
> > 
> > Eric,
> > 
> > If JS is not available, then '''<span id="version_switcher">''' will contain
> the
> > release number, hence, for the user it will look like docs without this
patch
> > applied.
> 
> Fair enough, assuming that this is true for all the places where
> html_short_title was previously used (if there are more than one).

I' check that.  Don't apply this version of the patch please ;)
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+