Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(180859)

#16314: Support xz compression in distutils

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 8 months ago by storchaka+cpython
Modified:
4 years, 3 months ago
Reviewers:
berker.peksag, merwok, pitrou
CC:
nadeem.vawda, tarek_ziade.org, jwilk_jwilk.net, ned.deily, eric.araujo, Arfrever, devnull_psf.upfronthosting.co.za, storchaka
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Total comments: 8

Patch Set 4 #

Total comments: 8

Patch Set 5 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/distutils/apiref.rst View 1 2 3 4 1 chunk +20 lines, -12 lines 0 comments Download
Doc/distutils/builtdist.rst View 1 2 3 4 4 chunks +27 lines, -18 lines 0 comments Download
Doc/distutils/sourcedist.rst View 1 2 3 4 2 chunks +7 lines, -1 line 0 comments Download
Doc/whatsnew/3.5.rst View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
Lib/distutils/archive_util.py View 1 2 3 4 3 chunks +12 lines, -9 lines 0 comments Download
Lib/distutils/command/bdist_dumb.py View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
Lib/distutils/command/bdist.py View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
Lib/distutils/tests/test_archive_util.py View 1 2 3 4 14 chunks +104 lines, -50 lines 0 comments Download
Lib/distutils/tests/test_bdist.py View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
berkerpeksag
http://bugs.python.org/review/16314/diff/14251/Doc/distutils/apiref.rst File Doc/distutils/apiref.rst (right): http://bugs.python.org/review/16314/diff/14251/Doc/distutils/apiref.rst#newcode877 Doc/distutils/apiref.rst:877: Returns the name of the archive file. Needs a ...
4 years, 3 months ago #1
storchaka_gmail.com
http://bugs.python.org/review/16314/diff/14251/Lib/distutils/archive_util.py File Lib/distutils/archive_util.py (right): http://bugs.python.org/review/16314/diff/14251/Lib/distutils/archive_util.py#newcode61 Lib/distutils/archive_util.py:61: None. ("compress" will be deprecated in Python 3.2) On ...
4 years, 3 months ago #2
eric.araujo
http://bugs.python.org/review/16314/diff/14251/Lib/distutils/archive_util.py File Lib/distutils/archive_util.py (right): http://bugs.python.org/review/16314/diff/14251/Lib/distutils/archive_util.py#newcode61 Lib/distutils/archive_util.py:61: None. ("compress" will be deprecated in Python 3.2) >> ...
4 years, 3 months ago #3
storchaka_gmail.com
http://bugs.python.org/review/16314/diff/14251/Lib/distutils/archive_util.py File Lib/distutils/archive_util.py (right): http://bugs.python.org/review/16314/diff/14251/Lib/distutils/archive_util.py#newcode61 Lib/distutils/archive_util.py:61: None. ("compress" will be deprecated in Python 3.2) On ...
4 years, 3 months ago #4
AntoinePitrou
http://bugs.python.org/review/16314/diff/14316/Doc/distutils/apiref.rst File Doc/distutils/apiref.rst (right): http://bugs.python.org/review/16314/diff/14316/Doc/distutils/apiref.rst#newcode888 Doc/distutils/apiref.rst:888: and the compression utility named by *compress* must be ...
4 years, 3 months ago #5
storchaka_gmail.com
4 years, 3 months ago #6
http://bugs.python.org/review/16314/diff/14316/Doc/distutils/apiref.rst
File Doc/distutils/apiref.rst (right):

http://bugs.python.org/review/16314/diff/14316/Doc/distutils/apiref.rst#newco...
Doc/distutils/apiref.rst:888: and the compression utility named by *compress*
must be on the default
On 2015/04/09 22:05:43, AntoinePitrou wrote:
> This is only true for the "compress" compression mode, which is kindof
obsolete
> anyway.

Done.

http://bugs.python.org/review/16314/diff/14316/Doc/distutils/builtdist.rst
File Doc/distutils/builtdist.rst (right):

http://bugs.python.org/review/16314/diff/14316/Doc/distutils/builtdist.rst#ne...
Doc/distutils/builtdist.rst:117: :program:`bzip2`, :program:`xz`, or
:program:`compress`
On 2015/04/09 22:05:43, AntoinePitrou wrote:
> Unless I'm missing something, neither "gzip", "bzip2" nor "xz" are required.

Done.

http://bugs.python.org/review/16314/diff/14316/Lib/distutils/tests/test_archi...
File Lib/distutils/tests/test_archive_util.py (right):

http://bugs.python.org/review/16314/diff/14316/Lib/distutils/tests/test_archi...
Lib/distutils/tests/test_archive_util.py:101: def _make_tarball1(self, tmpdir,
target_name, suffix, **kwargs):
On 2015/04/09 22:05:43, AntoinePitrou wrote:
> Perhaps use another name than "_make_tarball1"?

Renamed to _make_tarball and got rid of old _make_tarball.

http://bugs.python.org/review/16314/diff/14316/Lib/distutils/tests/test_archi...
Lib/distutils/tests/test_archive_util.py:136: def _create_files1(self):
On 2015/04/09 22:05:43, AntoinePitrou wrote:
> Same here.

Renamed to _create_files and got rid of old _create_files.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+