Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(194)

#1621: Do not assume signed integer overflow behavior

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 3 months ago by greg
Modified:
3 years, 5 months ago
Reviewers:
storchaka+cpython, vadmium+py
CC:
loewis, nnorwitz_gmail.com, jcea, mark.dickinson, AntoinePitrou, haypo, Alexandre Vassalotti, cartman, jmatejek_suse.com, jwilk_jwilk.net, alex, dmalcolm, devnull_psf.upfronthosting.co.za, cploomis_gmail.com, Martin Panter, storchaka, ztane, fweimer_redhat.com, noloader_gmail.com, xiang.zhang, sir-sigurd, mariatta.wijaya+miss-islington_gmail.com
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 3

Patch Set 3 #

Patch Set 4 #

Total comments: 1

Patch Set 5 #

Patch Set 6 #

Patch Set 7 #

Patch Set 8 #

Patch Set 9 #

Patch Set 10 #

Patch Set 11 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Objects/listobject.c View 1 2 3 4 5 6 7 8 9 10 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4
storchaka
http://bugs.python.org/review/1621/diff/17873/Modules/_elementtree.c File Modules/_elementtree.c (right): http://bugs.python.org/review/1621/diff/17873/Modules/_elementtree.c#newcode1728 Modules/_elementtree.c:1728: for (cur = start, i = 0; i < ...
3 years, 6 months ago #1
Martin Panter
https://bugs.python.org/review/1621/diff/17873/Modules/_elementtree.c File Modules/_elementtree.c (right): https://bugs.python.org/review/1621/diff/17873/Modules/_elementtree.c#newcode1728 Modules/_elementtree.c:1728: for (cur = start, i = 0; i < ...
3 years, 6 months ago #2
Martin Panter
https://bugs.python.org/review/1621/diff/17873/Modules/_elementtree.c File Modules/_elementtree.c (right): https://bugs.python.org/review/1621/diff/17873/Modules/_elementtree.c#newcode1728 Modules/_elementtree.c:1728: for (cur = start, i = 0; i < ...
3 years, 6 months ago #3
Martin Panter
3 years, 6 months ago #4
https://bugs.python.org/review/1621/diff/17932/Objects/listobject.c
File Objects/listobject.c (right):

https://bugs.python.org/review/1621/diff/17932/Objects/listobject.c#newcode849
Objects/listobject.c:849: ;
I think empty curly brackets would be much clearer here than the empty semicolon
statement. Recently PEP 7 was updated to say “braces are strongly preferred”. Or
you could reverse the sense of the condition:

if (m < ...) {
    /* Make room */
}
/* Else . . . */
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+