Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(150890)

#16145: Abort in _csv module

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 5 months ago by Arfrever.FTA
Modified:
6 years, 4 months ago
Reviewers:
storchaka, stefan-usenet
CC:
Georg, AntoinePitrou, haypo, larry, python_rogerbinns.com, Arfrever, r.david.murray, asvetlov, skrah, devnull_psf.upfronthosting.co.za, storchaka
Visibility:
Public.

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/test/test_csv.py View 1 chunk +11 lines, -0 lines 0 comments Download
Modules/_csv.c View 8 chunks +17 lines, -5 lines 4 comments Download
Modules/_testcapimodule.c View 2 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 2
storchaka_gmail.com
http://bugs.python.org/review/16145/diff/6185/Modules/_csv.c File Modules/_csv.c (right): http://bugs.python.org/review/16145/diff/6185/Modules/_csv.c#newcode1145 Modules/_csv.c:1145: if (PyUnicode_READY(self->dialect->lineterminator) == -1) This is not needed. lineterminator ...
6 years, 4 months ago #1
stefan-usenet_bytereef.org
6 years, 4 months ago #2
http://bugs.python.org/review/16145/diff/6185/Modules/_csv.c
File Modules/_csv.c (right):

http://bugs.python.org/review/16145/diff/6185/Modules/_csv.c#newcode1145
Modules/_csv.c:1145: if (PyUnicode_READY(self->dialect->lineterminator) == -1)
Yes, it's redundant. I put it in as a safety measure in case I overlooked a path
through which a DialectObject can be created.

Now that we have a second opinion, I'll take it out.

http://bugs.python.org/review/16145/diff/6185/Modules/_csv.c#newcode1418
Modules/_csv.c:1418: "dialect name must be a string or unicode");
OK.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+