Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(252)

#16113: Add SHA-3 (Keccak) support

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 2 months ago by lists
Modified:
1 year, 3 months ago
Reviewers:
pitrou, greg
CC:
tim.peters, loewis, rhettinger, gregory.p.smith, jcea, AntoinePitrou, haypo, larry, christian.heimes, habnabit, ezio.melotti, spatz_psybear.com, Arfrever, asvetlov, mgorny_gentoo.org, devnull_psf.upfronthosting.co.za, sbt, be_bjrn.se, dstufft, wmark_hurrikane.de, haakon
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Total comments: 17

Patch Set 4 #

Patch Set 5 #

Patch Set 6 #

Total comments: 6

Patch Set 7 #

Patch Set 8 #

Patch Set 9 #

Total comments: 8

Patch Set 10 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/hashlib.rst View 1 2 3 4 5 6 7 8 9 2 chunks +29 lines, -1 line 0 comments Download
Lib/hashlib.py View 1 2 3 4 5 6 7 8 9 3 chunks +14 lines, -1 line 0 comments Download
Lib/test/test_hashlib.py View 1 2 3 4 5 6 7 8 9 10 chunks +157 lines, -18 lines 0 comments Download
Modules/_sha3/README.txt View 1 2 3 4 5 6 7 8 9 1 chunk +11 lines, -0 lines 0 comments Download
Modules/_sha3/cleanup.py View 1 2 3 4 5 6 7 8 9 1 chunk +50 lines, -0 lines 0 comments Download
Modules/_sha3/clinic/sha3module.c.h View 1 2 3 4 5 6 7 8 9 1 chunk +148 lines, -0 lines 0 comments Download
Modules/_sha3/kcp/KeccakHash.c View 1 2 3 4 5 6 7 8 9 1 chunk +82 lines, -0 lines 0 comments Download
Modules/_sha3/kcp/KeccakHash.h View 1 2 3 4 5 6 7 8 9 1 chunk +114 lines, -0 lines 0 comments Download
Modules/_sha3/kcp/KeccakP-1600-64.macros View 1 2 3 4 5 6 7 8 9 1 chunk +2208 lines, -0 lines 0 comments Download
Modules/_sha3/kcp/KeccakP-1600-SnP-opt32.h View 1 2 3 4 5 6 7 8 9 1 chunk +37 lines, -0 lines 0 comments Download
Modules/_sha3/kcp/KeccakP-1600-SnP-opt64.h View 1 2 3 4 5 6 7 8 9 1 chunk +49 lines, -0 lines 0 comments Download
Modules/_sha3/kcp/KeccakP-1600-SnP.h View 1 2 3 4 5 6 7 8 9 1 chunk +7 lines, -0 lines 0 comments Download
Modules/_sha3/kcp/KeccakP-1600-inplace32BI.c View 1 2 3 4 5 6 7 8 9 1 chunk +1160 lines, -0 lines 0 comments Download
Modules/_sha3/kcp/KeccakP-1600-opt64-config.h View 1 2 3 4 5 6 7 8 9 1 chunk +3 lines, -0 lines 0 comments Download
Modules/_sha3/kcp/KeccakP-1600-opt64.c View 1 2 3 4 5 6 7 8 9 1 chunk +474 lines, -0 lines 0 comments Download
Modules/_sha3/kcp/KeccakP-1600-unrolling.macros View 1 2 3 4 5 6 7 8 9 1 chunk +185 lines, -0 lines 0 comments Download
Modules/_sha3/kcp/KeccakSponge.c View 1 2 3 4 5 6 7 8 9 1 chunk +92 lines, -0 lines 0 comments Download
Modules/_sha3/kcp/KeccakSponge.h View 1 2 3 4 5 6 7 8 9 1 chunk +172 lines, -0 lines 0 comments Download
Modules/_sha3/kcp/KeccakSponge.inc View 1 2 3 4 5 6 7 8 9 1 chunk +332 lines, -0 lines 0 comments Download
Modules/_sha3/kcp/PlSnP-Fallback.inc View 1 2 3 4 5 6 7 8 9 1 chunk +257 lines, -0 lines 0 comments Download
Modules/_sha3/kcp/SnP-Relaned.h View 1 2 3 4 5 6 7 8 9 1 chunk +134 lines, -0 lines 0 comments Download
Modules/_sha3/kcp/align.h View 1 2 3 4 5 6 7 8 9 1 chunk +35 lines, -0 lines 0 comments Download
Modules/_sha3/sha3module.c View 1 2 3 4 5 6 7 8 9 1 chunk +749 lines, -0 lines 0 comments Download
Modules/hashlib.h View 1 2 3 4 5 6 7 8 9 1 chunk +11 lines, -8 lines 0 comments Download

Messages

Total messages: 9
AntoinePitrou
Here are a couple (mostly minor) comments. http://bugs.python.org/review/16113/diff/6161/Modules/_sha3/keccak/KeccakF-1600-opt32.c File Modules/_sha3/keccak/KeccakF-1600-opt32.c (right): http://bugs.python.org/review/16113/diff/6161/Modules/_sha3/keccak/KeccakF-1600-opt32.c#newcode22 Modules/_sha3/keccak/KeccakF-1600-opt32.c:22: typedef unsigned ...
5 years, 2 months ago #1
gregory.p.smith
http://bugs.python.org/review/16113/diff/6161/Modules/_sha3/sha3module.c File Modules/_sha3/sha3module.c (right): http://bugs.python.org/review/16113/diff/6161/Modules/_sha3/sha3module.c#newcode24 Modules/_sha3/sha3module.c:24: * Kebbak functions and global data as static. The ...
5 years, 2 months ago #2
gregory.p.smith
http://bugs.python.org/review/16113/diff/6161/Lib/test/test_hashlib.py File Lib/test/test_hashlib.py (right): http://bugs.python.org/review/16113/diff/6161/Lib/test/test_hashlib.py#newcode352 Lib/test/test_hashlib.py:352: add a # TODO comment in here asking for ...
5 years, 2 months ago #3
christian.heimes
Thanks for the review! Stay tuned for another patch in a couple of hours. http://bugs.python.org/review/16113/diff/6161/Lib/test/test_hashlib.py ...
5 years, 2 months ago #4
AntoinePitrou
A couple more comments. As for the uint64 stuff, I think the best will be ...
5 years, 2 months ago #5
gregory.p.smith
http://bugs.python.org/review/16113/diff/6174/Modules/hashlib.h File Modules/hashlib.h (right): http://bugs.python.org/review/16113/diff/6174/Modules/hashlib.h#newcode59 Modules/hashlib.h:59: #define GIL_RELEASE_MINSIZE 2048 On 2012/10/05 23:27:10, AntoinePitrou wrote: > ...
5 years, 2 months ago #6
christian.heimes
http://bugs.python.org/review/16113/diff/6174/Modules/_sha3/sha3module.c File Modules/_sha3/sha3module.c (right): http://bugs.python.org/review/16113/diff/6174/Modules/_sha3/sha3module.c#newcode244 Modules/_sha3/sha3module.c:244: SHA3_copystate(newobj->hash_state, self->hash_state); On 2012/10/05 23:27:10, AntoinePitrou wrote: > Is ...
5 years, 2 months ago #7
gregory.p.smith
https://bugs.python.org/review/16113/diff/17433/Doc/library/hashlib.rst File Doc/library/hashlib.rst (right): https://bugs.python.org/review/16113/diff/17433/Doc/library/hashlib.rst#newcode10 Doc/library/hashlib.rst:10: .. index:: add new algorithms to the index? https://bugs.python.org/review/16113/diff/17433/Doc/library/hashlib.rst#newcode66 ...
1 year, 6 months ago #8
gregory.p.smith
1 year, 6 months ago #9
https://bugs.python.org/review/16113/diff/17433/Lib/test/test_hashlib.py
File Lib/test/test_hashlib.py (right):

https://bugs.python.org/review/16113/diff/17433/Lib/test/test_hashlib.py#newc...
Lib/test/test_hashlib.py:314: #self.check_blocksize_name('sha3_224', 128, 64)
commented out?

https://bugs.python.org/review/16113/diff/17433/Modules/hashlib.h
File Modules/hashlib.h (right):

https://bugs.python.org/review/16113/diff/17433/Modules/hashlib.h#newcode5
Modules/hashlib.h:5: * of PyObject_GetBuffer.  Sets an exception and issues a
return NULL
update the comment.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7