Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(49085)

Delta Between Two Patch Sets: Lib/test/test_compileall.py

Issue 16104: Use multiprocessing in compileall script
Left Patch Set: Created 5 years, 4 months ago
Right Patch Set: Created 5 years ago
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« Lib/compileall.py ('K') | « Lib/compileall.py ('k') | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 import sys 1 import sys
2 import compileall 2 import compileall
3 import importlib.util 3 import importlib.util
4 import os 4 import os
5 import py_compile 5 import py_compile
6 import shutil 6 import shutil
7 import struct 7 import struct
8 import tempfile 8 import tempfile
9 import time 9 import time
10 import unittest 10 import unittest
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
106 cached = importlib.util.cache_from_source(self.source_path, 106 cached = importlib.util.cache_from_source(self.source_path,
107 debug_override=not optimize) 107 debug_override=not optimize)
108 self.assertTrue(os.path.isfile(cached)) 108 self.assertTrue(os.path.isfile(cached))
109 cached2 = importlib.util.cache_from_source(self.source_path2, 109 cached2 = importlib.util.cache_from_source(self.source_path2,
110 debug_override=not optimize) 110 debug_override=not optimize)
111 self.assertTrue(os.path.isfile(cached2)) 111 self.assertTrue(os.path.isfile(cached2))
112 cached3 = importlib.util.cache_from_source(self.source_path3, 112 cached3 = importlib.util.cache_from_source(self.source_path3,
113 debug_override=not optimize) 113 debug_override=not optimize)
114 self.assertTrue(os.path.isfile(cached3)) 114 self.assertTrue(os.path.isfile(cached3))
115 115
116 @skipUnless(_have_multiprocessing, "requires multiprocessing")
berkerpeksag 2014/04/27 15:57:05 This should be @mock.patch('compileall.Proces
117 @mock.patch('compileall.ProcessPoolExecutor') 116 @mock.patch('compileall.ProcessPoolExecutor')
118 def test_compile_processes(self, pool_mock): 117 def test_compile_pool_called(self, pool_mock):
119 bar2fn = script_helper.make_script(self.directory, 'bar2', '') 118 compileall.compile_dir(self.directory, quiet=True, workers=5)
120 compileall.compile_dir(self.directory, quiet=True, processes=5)
121 self.assertTrue(pool_mock.called) 119 self.assertTrue(pool_mock.called)
122 120
123 def test_compile_processes_non_positive(self): 121 def test_compile_workers_non_positive(self):
124 # Test that `compile_dir` doesn't use ProcessPoolExecutor 122 with self.assertRaisesRegex(ValueError,
125 # when passing processes=1 123 "workers must be greater or equal to 0"):
126 bar2fn = script_helper.make_script(self.directory, 'bar2', '') 124 compileall.compile_dir(self.directory, workers=-1)
127 for value in (0, -1): 125
128 with self.assertRaises(ValueError) as cm: 126 @mock.patch('compileall.ProcessPoolExecutor')
129 compileall.compile_dir(self.directory, processes=value) 127 def test_compile_workers_cpu_count(self, pool_mock):
130 self.assertEqual(str(cm.exception), 128 compileall.compile_dir(self.directory, quiet=True, workers=0)
131 "processes must be greater than 0") 129 self.assertEqual(pool_mock.call_args[1]['max_workers'],
132 130 os.cpu_count())
133 @mock.patch('compileall.ProcessPoolExecutor', None) 131
berkerpeksag 2014/04/27 15:57:05 It would be good if you use a keyword-only argumen
132 @mock.patch('compileall.ProcessPoolExecutor')
133 @mock.patch('compileall.compile_file')
134 def test_compile_one_worker(self, compile_file_mock, pool_mock):
135 compileall.compile_dir(self.directory, quiet=True)
136 self.assertFalse(pool_mock.called)
137 self.assertTrue(compile_file_mock.called)
138
139 @mock.patch('compileall.ProcessPoolExecutor', new=None)
134 def test_compile_missing_multiprocessing(self): 140 def test_compile_missing_multiprocessing(self):
135 with self.assertRaises(ValueError) as cm: 141 with self.assertRaisesRegex(NotImplementedError,
136 compileall.compile_dir(self.directory, quiet=True, processes=5) 142 "multiprocessing support not available"):
137 self.assertEqual(str(cm.exception), 143 compileall.compile_dir(self.directory, quiet=True, workers=5)
138 "multiprocessing support not available")
139
140 144
141 class EncodingTest(unittest.TestCase): 145 class EncodingTest(unittest.TestCase):
142 """Issue 6716: compileall should escape source code when printing errors 146 """Issue 6716: compileall should escape source code when printing errors
143 to stdout.""" 147 to stdout."""
144 148
145 def setUp(self): 149 def setUp(self):
146 self.directory = tempfile.mkdtemp() 150 self.directory = tempfile.mkdtemp()
147 self.source_path = os.path.join(self.directory, '_test.py') 151 self.source_path = os.path.join(self.directory, '_test.py')
148 with open(self.source_path, 'w', encoding='utf-8') as file: 152 with open(self.source_path, 'w', encoding='utf-8') as file:
149 file.write('# -*- coding: utf-8 -*-\n') 153 file.write('# -*- coding: utf-8 -*-\n')
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
297 os.mkdir(subpackage) 301 os.mkdir(subpackage)
298 subinitfn = script_helper.make_script(subpackage, '__init__', '') 302 subinitfn = script_helper.make_script(subpackage, '__init__', '')
299 hamfn = script_helper.make_script(subpackage, 'ham', '') 303 hamfn = script_helper.make_script(subpackage, 'ham', '')
300 self.assertRunOK('-q', '-l', self.pkgdir) 304 self.assertRunOK('-q', '-l', self.pkgdir)
301 self.assertNotCompiled(subinitfn) 305 self.assertNotCompiled(subinitfn)
302 self.assertFalse(os.path.exists(os.path.join(subpackage, '__pycache__')) ) 306 self.assertFalse(os.path.exists(os.path.join(subpackage, '__pycache__')) )
303 self.assertRunOK('-q', self.pkgdir) 307 self.assertRunOK('-q', self.pkgdir)
304 self.assertCompiled(subinitfn) 308 self.assertCompiled(subinitfn)
305 self.assertCompiled(hamfn) 309 self.assertCompiled(hamfn)
306 310
311 def test_recursion_limit(self):
312 subpackage = os.path.join(self.pkgdir, 'spam')
313 subpackage2 = os.path.join(subpackage, 'ham')
314 subpackage3 = os.path.join(subpackage2, 'eggs')
315 for pkg in (subpackage, subpackage2, subpackage3):
316 script_helper.make_pkg(pkg)
317
318 subinitfn = os.path.join(subpackage, '__init__.py')
319 hamfn = script_helper.make_script(subpackage, 'ham', '')
320 spamfn = script_helper.make_script(subpackage2, 'spam', '')
321 eggfn = script_helper.make_script(subpackage3, 'egg', '')
322
323 self.assertRunOK('-q', '-r 0', self.pkgdir)
324 self.assertNotCompiled(subinitfn)
325 self.assertFalse(
326 os.path.exists(os.path.join(subpackage, '__pycache__')))
327
328 self.assertRunOK('-q', '-r 1', self.pkgdir)
329 self.assertCompiled(subinitfn)
330 self.assertCompiled(hamfn)
331 self.assertNotCompiled(spamfn)
332
333 self.assertRunOK('-q', '-r 2', self.pkgdir)
334 self.assertCompiled(subinitfn)
335 self.assertCompiled(hamfn)
336 self.assertCompiled(spamfn)
337 self.assertNotCompiled(eggfn)
338
339 self.assertRunOK('-q', '-r 5', self.pkgdir)
340 self.assertCompiled(subinitfn)
341 self.assertCompiled(hamfn)
342 self.assertCompiled(spamfn)
343 self.assertCompiled(eggfn)
344
307 def test_quiet(self): 345 def test_quiet(self):
308 noisy = self.assertRunOK(self.pkgdir) 346 noisy = self.assertRunOK(self.pkgdir)
309 quiet = self.assertRunOK('-q', self.pkgdir) 347 quiet = self.assertRunOK('-q', self.pkgdir)
310 self.assertNotEqual(b'', noisy) 348 self.assertNotEqual(b'', noisy)
311 self.assertEqual(b'', quiet) 349 self.assertEqual(b'', quiet)
312 350
313 def test_regexp(self): 351 def test_regexp(self):
314 self.assertRunOK('-q', '-x', r'ba[^\\/]*$', self.pkgdir) 352 self.assertRunOK('-q', '-x', r'ba[^\\/]*$', self.pkgdir)
315 self.assertNotCompiled(self.barfn) 353 self.assertNotCompiled(self.barfn)
316 self.assertCompiled(self.initfn) 354 self.assertCompiled(self.initfn)
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
404 self.assertRegex(out, b'rror') 442 self.assertRegex(out, b'rror')
405 self.assertNotCompiled(bingfn) 443 self.assertNotCompiled(bingfn)
406 self.assertCompiled(self.initfn) 444 self.assertCompiled(self.initfn)
407 self.assertCompiled(self.barfn) 445 self.assertCompiled(self.barfn)
408 446
409 def test_invalid_arg_produces_message(self): 447 def test_invalid_arg_produces_message(self):
410 out = self.assertRunOK('badfilename') 448 out = self.assertRunOK('badfilename')
411 self.assertRegex(out, b"Can't list 'badfilename'") 449 self.assertRegex(out, b"Can't list 'badfilename'")
412 450
413 @skipUnless(_have_multiprocessing, "requires multiprocessing") 451 @skipUnless(_have_multiprocessing, "requires multiprocessing")
414 def test_processes(self): 452 def test_workers(self):
415 bar2fn = script_helper.make_script(self.directory, 'bar2', '') 453 bar2fn = script_helper.make_script(self.directory, 'bar2', '')
416 files = [] 454 files = []
417 for suffix in range(5): 455 for suffix in range(5):
418 pkgdir = os.path.join(self.directory, 'foo{}'.format(suffix)) 456 pkgdir = os.path.join(self.directory, 'foo{}'.format(suffix))
419 os.mkdir(pkgdir) 457 os.mkdir(pkgdir)
420 fn = script_helper.make_script(pkgdir, '__init__', '') 458 fn = script_helper.make_script(pkgdir, '__init__', '')
421 files.append(script_helper.make_script(pkgdir, 'bar2', '')) 459 files.append(script_helper.make_script(pkgdir, 'bar2', ''))
422 460
423 self.assertRunOK(self.directory, '-j', '0') 461 self.assertRunOK(self.directory, '-j', '0')
424 self.assertCompiled(bar2fn) 462 self.assertCompiled(bar2fn)
425 for file in files: 463 for file in files:
426 self.assertCompiled(file) 464 self.assertCompiled(file)
427 465
428 @mock.patch('compileall.compile_dir') 466 @mock.patch('compileall.compile_dir')
429 def test_processes_available_cores(self, compile_dir): 467 def test_workers_available_cores(self, compile_dir):
430 with mock.patch("sys.argv", 468 with mock.patch("sys.argv",
431 new=[sys.executable, self.directory, "-j0"]): 469 new=[sys.executable, self.directory, "-j0"]):
432 compileall.main() 470 compileall.main()
433 self.assertTrue(compile_dir.called) 471 self.assertTrue(compile_dir.called)
434 self.assertEqual(compile_dir.call_args[-1]['processes'], 472 self.assertEqual(compile_dir.call_args[-1]['workers'],
435 os.cpu_count()) 473 os.cpu_count())
436 474
437 475
438 if __name__ == "__main__": 476 if __name__ == "__main__":
439 unittest.main() 477 unittest.main()
LEFTRIGHT

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+