Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7)

#15573: Support unknown formats in memoryview comparisons

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 8 months ago by stefan
Modified:
7 years, 7 months ago
Reviewers:
ncoghlan, martin
CC:
loewis, Georg, mark.dickinson, Nick Coghlan, AntoinePitrou, haypo, christian.heimes, Arfrever, skrah, meadori, devnull_psf.upfronthosting.co.za
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 18

Patch Set 3 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/stdtypes.rst View 1 2 5 chunks +57 lines, -21 lines 0 comments Download
Doc/whatsnew/3.3.rst View 1 2 2 chunks +6 lines, -1 line 0 comments Download
Lib/test/test_buffer.py View 1 2 30 chunks +442 lines, -80 lines 0 comments Download
Objects/memoryobject.c View 1 2 16 chunks +294 lines, -54 lines 0 comments Download

Messages

Total messages: 6
Nick Coghlan
It appears the odd signature for the cmp_ functions extends to more than just the ...
7 years, 7 months ago #1
stefan-usenet_bytereef.org
Thanks for the comments. The cmp* functions could be renamed, but they are all still ...
7 years, 7 months ago #2
loewis
http://bugs.python.org/review/15573/diff/5737/Doc/library/stdtypes.rst File Doc/library/stdtypes.rst (right): http://bugs.python.org/review/15573/diff/5737/Doc/library/stdtypes.rst#newcode2508 Doc/library/stdtypes.rst:2508: in comparisons. Proposal for rephrasing the last sentence: "While ...
7 years, 7 months ago #3
stefan-usenet_bytereef.org
http://bugs.python.org/review/15573/diff/5737/Doc/library/stdtypes.rst File Doc/library/stdtypes.rst (right): http://bugs.python.org/review/15573/diff/5737/Doc/library/stdtypes.rst#newcode2508 Doc/library/stdtypes.rst:2508: in comparisons. Yes, I don't like the original either. ...
7 years, 7 months ago #4
Nick Coghlan
This is starting to look pretty solid to me. http://bugs.python.org/review/15573/diff/5737/Doc/library/stdtypes.rst File Doc/library/stdtypes.rst (right): http://bugs.python.org/review/15573/diff/5737/Doc/library/stdtypes.rst#newcode2508 Doc/library/stdtypes.rst:2508: ...
7 years, 7 months ago #5
stefan-usenet_bytereef.org
7 years, 7 months ago #6
http://bugs.python.org/review/15573/diff/5737/Doc/library/stdtypes.rst
File Doc/library/stdtypes.rst (right):

http://bugs.python.org/review/15573/diff/5737/Doc/library/stdtypes.rst#newcod...
Doc/library/stdtypes.rst:2508: in comparisons.
Sounds good to me. In the new patch I changed "two memoryviews" to "memoryview
and PEP-3118 exporter".

http://bugs.python.org/review/15573/diff/5737/Objects/memoryobject.c
File Objects/memoryobject.c (right):

http://bugs.python.org/review/15573/diff/5737/Objects/memoryobject.c#newcode276
Objects/memoryobject.c:276: cmp_shape(const Py_buffer *dest, const Py_buffer
*src)
OK, done.

http://bugs.python.org/review/15573/diff/5737/Objects/memoryobject.c#newcode2627
Objects/memoryobject.c:2627: 
Also done.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+