Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(261222)

#15381: Optimize BytesIO to so less reallocations when written, similarly to StringIO

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 1 month ago by eliben
Modified:
4 years, 6 months ago
Reviewers:
pitrou, storchaka
CC:
Nick Coghlan, AntoinePitrou, scoder, haypo, Benjamin Peterson, stutzbach, Arfrever, eli.bendersky, meadori, tshepang, devnull_psf.upfronthosting.co.za, jcon, berkerpeksag, hynek, dw, storchaka, kmike84_gmail.com
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Patch Set 4 #

Patch Set 5 #

Patch Set 6 #

Total comments: 1

Patch Set 7 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/test/test_memoryio.py View 1 2 3 4 5 6 1 chunk +2 lines, -3 lines 0 comments Download
Modules/_io/bytesio.c View 1 2 3 4 5 6 38 chunks +152 lines, -186 lines 0 comments Download

Messages

Total messages: 3
AntoinePitrou
http://bugs.python.org/review/15381/diff/12708/Modules/_io/bytesio.c File Modules/_io/bytesio.c (right): http://bugs.python.org/review/15381/diff/12708/Modules/_io/bytesio.c#newcode418 Modules/_io/bytesio.c:418: self->pos == n && n == PyBytes_GET_SIZE(self->buf) && This ...
4 years, 6 months ago #1
AntoinePitrou
Looks good to me, thank you.
4 years, 6 months ago #2
storchaka_gmail.com
4 years, 6 months ago #3
On 2015/01/31 22:48:09, AntoinePitrou wrote:
> Looks good to me, thank you.

Thank you for your review. Will commit after issue23099.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+