Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(94844)

#15363: Idle/tkinter ~x.py 'save as' fails. closes idle

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 4 months ago by tjreedy
Modified:
1 month, 3 weeks ago
Reviewers:
andrew.svetlov, storchaka, ioanszalacsi
CC:
loewis, terry.reedy, serwy, storchaka
Visibility:
Public.

Patch Set 1 #

Total comments: 1

Patch Set 2 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/idlelib/IOBinding.py View 1 1 chunk +8 lines, -4 lines 3 comments Download

Messages

Total messages: 3
asvetlov
http://bugs.python.org/review/15363/diff/5413/Lib/idlelib/IOBinding.py File Lib/idlelib/IOBinding.py (right): http://bugs.python.org/review/15363/diff/5413/Lib/idlelib/IOBinding.py#newcode510 Lib/idlelib/IOBinding.py:510: # Fix Tcl/Tk Tilde Substitution problem on Windows I ...
7 years, 3 months ago #1
storchaka_gmail.com
Just several nitpicks. http://bugs.python.org/review/15363/diff/13046/Lib/idlelib/IOBinding.py File Lib/idlelib/IOBinding.py (right): http://bugs.python.org/review/15363/diff/13046/Lib/idlelib/IOBinding.py#newcode503 Lib/idlelib/IOBinding.py:503: dirname, base = os.path.split(self.filename) Either dirname ...
5 years, 1 month ago #2
Io Sz
1 month, 3 weeks ago #3
On 2014/10/12 11:40:28, storchaka_gmail.com wrote:
> Just several nitpicks.
> 
> bhttp://bugs.python.org/review/15363/diff/13046/Lib/idlelib/IOBinding.py
> File Lib/idlelib/IOBinding.py (right):
> 
>
http://bugs.python.org/review/15363/diff/13046/Lib/idlelib/IOBinding.py#newco...
> Lib/idlelib/IOBinding.py:503: dirname, base = os.path.split(self.filename)
> Either dirname and basename or dir and base for consistency.
> 
>
http://bugs.python.org/review/15363/diff/13046/Lib/idlelib/IOBinding.py#newco...
> Lib/idlelib/IOBinding.py:504: if base.startswith('~') and sys.platform[:3] ==
> 'win':
> base.startswith('~') but sys.platform[:3] == 'win'. This is inconsistent.
> 
>
http://bugs.python.org/review/15363/diff/13046/Lib/idlelib/IOBinding.py#newco...
> Lib/idlelib/IOBinding.py:506: base = './' + base  # Escape the tilde
> Or rather os.path.join(os.path.curdir, base).
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+